Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a check for ICEControlling when parsing first TCP STUN message #249

Closed
jeremija opened this issue Jul 18, 2020 · 0 comments · Fixed by #250
Closed

Remove a check for ICEControlling when parsing first TCP STUN message #249

jeremija opened this issue Jul 18, 2020 · 0 comments · Fixed by #250

Comments

@jeremija
Copy link
Member

Your environment.

  • Version: v2.0.0-rc.6
  • Browser: Firefox

What did you do?

The check for ICE controlling is most likely not necessary. I couldn't establish a TCP Peer Connection that was initiated by the server, with passive server candidate and an active browser candidate.

What did you expect?

The connection should succeed.

What happened?

The connection failed because of this check:

ice/tcp_mux.go

Lines 147 to 156 in e8ac363

// Firefox will send ICEControlling for its Active canddiate. We
// currently support passive local TCP candidates only.
//
// TODO: not sure what will be sent for caniddate with tcptype S-O.
_, err = msg.Get(stun.AttrICEControlling)
if err != nil {
m.closeAndLogError(conn)
m.params.Logger.Warnf("No ICEControlling attribute in STUN message from %s to %s\n", conn.RemoteAddr(), conn.LocalAddr())
return
}

Will follow up with a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant