Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run agent task after close #183

Merged
merged 1 commit into from
May 3, 2020
Merged

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented May 3, 2020

Fix send on closed channel panic.

Reference issue

Fixes #182

Fix send on closed channel panic.
@at-wat at-wat force-pushed the fix-running-task-after-close branch from f09a281 to 733738a Compare May 3, 2020 04:19
@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #183 into master will decrease coverage by 0.16%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   78.81%   78.65%   -0.17%     
==========================================
  Files          24       24              
  Lines        1964     1972       +8     
==========================================
+ Hits         1548     1551       +3     
- Misses        290      294       +4     
- Partials      126      127       +1     
Flag Coverage Δ
#go 78.65% <71.42%> (-0.17%) ⬇️
#wasm 18.10% <0.00%> (-0.08%) ⬇️
Impacted Files Coverage Δ
agent.go 81.08% <71.42%> (-0.18%) ⬇️
gather.go 68.79% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91446b...733738a. Read the comment docs.

@Sean-Der Sean-Der merged commit 88b716c into master May 3, 2020
@Sean-Der Sean-Der deleted the fix-running-task-after-close branch June 22, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

panic: send on closed channel in github.com/pion/ice.(*Agent).updateConnectionState
2 participants