Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose stunGatherTimeout in Agent struct #668

Merged

Conversation

stephanrotolante
Copy link
Contributor

@stephanrotolante stephanrotolante commented Apr 3, 2024

Description

Allows to configure STUN timeout from the config

Reference issue

Resolves pion/webrtc#2668

@Sean-Der Sean-Der force-pushed the feature/expose-stun-timeout branch from 6b9e425 to d47c426 Compare April 3, 2024 03:00
@Sean-Der
Copy link
Member

Sean-Der commented Apr 3, 2024

Nice! This looks perfect to me @stephanrotolante

When all the tests go green go ahead and merge!

Then in https://github.com/pion/ice/releases/new create v3.0.4 and do Generate release notes. Then you can open up a pion/webrtc PR and add it to the SettingEngine.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.65%. Comparing base (a12f670) to head (d47c426).

Files Patch % Lines
agent_config.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #668      +/-   ##
==========================================
- Coverage   78.69%   78.65%   -0.05%     
==========================================
  Files          42       42              
  Lines        4698     4703       +5     
==========================================
+ Hits         3697     3699       +2     
- Misses        769      771       +2     
- Partials      232      233       +1     
Flag Coverage Δ
go 78.65% <57.14%> (-0.05%) ⬇️
wasm 22.45% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanrotolante stephanrotolante merged commit edaa25e into pion:master Apr 3, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to configure ice candidates gathering timeouts
2 participants