Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure ice candidates gathering timeouts #2668

Closed
only77nt opened this issue Feb 7, 2024 · 0 comments · Fixed by pion/ice#668 or #2725
Closed

Ability to configure ice candidates gathering timeouts #2668

only77nt opened this issue Feb 7, 2024 · 0 comments · Fixed by pion/ice#668 or #2725

Comments

@only77nt
Copy link

only77nt commented Feb 7, 2024

Summary

I'm trying to reduce ice candidates gathering timeouts (especially srflx and relay). I can do this by changing the values of constants, but after next webrtc update this changes will be lost

Srflx candidate gathering timeout constant: https://github.com/pion/ice/blob/c0a6ffa458f1a02d19220bded34b221cf63f15a4/gather.go#L25
Relay candidate gathering timeout constant: https://github.com/pion/turn/blob/fb0ab51601b13496493144db894651c7df56fb68/internal/client/transaction.go#L15

Motivation

Ability to configure gathering timeout for each candidate in webrtc.SettingEngine (similar to how it is done with AcceptanceMinWait). Very useful solution for fine tuning

stephanrotolante added a commit that referenced this issue Apr 3, 2024
stephanrotolante added a commit that referenced this issue Apr 3, 2024
stephanrotolante added a commit that referenced this issue Apr 3, 2024
stephanrotolante added a commit that referenced this issue Apr 3, 2024
stephanrotolante added a commit that referenced this issue Apr 3, 2024
Sean-Der pushed a commit that referenced this issue Apr 3, 2024
Sean-Der pushed a commit that referenced this issue Apr 3, 2024
ourwarmhouse added a commit to ourwarmhouse/store-backend-go that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants