Add support for additional values for the bandwidth type

[babolivier]

Description

Support additional bandwidth types defined in RFC3890 and RFC3556

Reference issue

Fixes #99

[codecov]

Codecov Report

Merging #100 (a641650) into master (4f18d96) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          11       11           
  Lines         968      968           
=======================================
  Hits          595      595           
  Misses        271      271           
  Partials      102      102           

Flag	Coverage Δ
go	61.46% <0.00%> (ø)
wasm	61.46% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
unmarshal.go	57.80% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f18d96...1f0ea2f. Read the comment docs.

[Sean-Der]

Nice! I would love to take this @babolivier mind adding a simple test?

Just something to be sure it doesn't accidently get regressed in the future :)

[babolivier]

Nice! I would love to take this @babolivier mind adding a simple test?

Just something to be sure it doesn't accidently get regressed in the future :)

Makes total sense, I've added lines with these new types to MediaBandwidthSDP so they get passed through Marshal() in TestRoundTrip.

Also the CI is complaining about my commit message, but I can't see what's wrong with it. Am I required to add a body to the message?

[Sean-Der]

Merged with f6cf15d

[Sean-Der]

@babolivier yea the commit message linter is annoying. We put it in because we were getting really bad commit messages FIX ERROR kind of thing. I wish the tooling was better, someday will get to it :)

Since you are using pion/sdp (and may make more improvements) would you be interested in being added to the org? You can make branches and review PRs. Then you can merge your own stuff when another Pion dev approves (or you can approve others).

Makes things easier you can pin against branches and test your stuff. Also will give me someone to add to reviews in the future for SDP work :)

[babolivier]

Since you are using pion/sdp (and may make more improvements) would you be interested in being added to the org? You can make branches and review PRs. Then you can merge your own stuff when another Pion dev approves (or you can approve others).

I'm sorry but while I'm using pion/sdp for what I'm working on right now (and I'm happy to open issues/PRs about issues or bugs I find) I'm not really interested in a more permanent involvement with the project 😅 Thanks for the offer though, and thanks for handling and merging this PR (as well as for the rest of your work on this project)!