Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more values for the bandwidth types when parsing b= attributes #99

Closed
babolivier opened this issue Feb 18, 2021 · 1 comment
Closed

Support more values for the bandwidth types when parsing b= attributes #99

babolivier opened this issue Feb 18, 2021 · 1 comment

Comments

@babolivier
Copy link
Contributor

Summary

Support more values for the bandwidth types when parsing b= attributes, namely the ones described in RFC3890 and RFC3556.

Motivation

Implementation of protocols using SDP (whether it's SIP, WebRTC or others) might want or need to use values for the bandwidth type other than the two values defined in RFC4566. Currently using anything other than CT or AS in the b= attribute of a SDP payload (either for the session or a media) and attempting to unmarshal it with pion/sdp results in an "invalid syntax" error. Because parsing this attribute happens in an unexported function in the unmarshal code, this support can't be added by the VoIP implementation using this library, so it needs to happen in this library itself.
@babolivier babolivier mentioned this issue Feb 18, 2021
Closed
@babolivier
Copy link
Contributor Author

Fixed by #100 (GitHub didn't pick it up because the change wasn't merged via a merge commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for additional values for the bandwidth type matrix-org/sdp
1 participant
@babolivier