Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support type BFCP #150

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add support type BFCP #150

merged 1 commit into from
Mar 28, 2024

Conversation

FizikRoot
Copy link
Contributor

Current polycom use SDP like

v=0
o=- 1674740882 1674740882 IN IP4 192.168.1.76
s=MRD=MRE MRC-V=1.0.1
c=IN IP4 192.168.1.76
b=AS:1024
t=0 0
a=sendrecv
a=vnd.polycom.MBA.p2p:v=1.0.1
m=audio 3230 RTP/AVP 118 115 114 9 102 113 101 103 0 8 15 18 119
a=sendrecv
a=rtpmap:118 SIRENLPR/48000/1
a=fmtp:118 bitrate=64000
a=rtpmap:115 G7221/32000
a=fmtp:115 bitrate=48000
a=rtpmap:114 G7221/32000
a=fmtp:114 bitrate=32000
a=rtpmap:9 G722/8000
a=fmtp:9 bitrate=64000
a=rtpmap:102 G7221/16000
a=fmtp:102 bitrate=32000
a=rtpmap:113 G7221/32000
a=fmtp:113 bitrate=24000
a=rtpmap:101 G7221/16000
a=fmtp:101 bitrate=24000
a=rtpmap:103 G7221/16000
a=fmtp:103 bitrate=16000
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:15 G728/8000
a=rtpmap:18 G729/8000
a=fmtp:18 annexb=no
a=rtpmap:119 telephone-event/8000
a=fmtp:119 0-15
m=video 3232 RTP/AVP 111 109 110 96 34 31 106 105 116
a=sendrecv
a=rtcp-fb:* nack pli
a=rtcp-fb:* ccm fir
a=rtcp-fb:* ccm tmmbr
a=vnd.polycom.forceVideoMode:9
a=rtpmap:111 H264/90000
a=fmtp:111 profile-level-id=64001f; packetization-mode=1; max-br=20010; sar=13
a=vnd.polycom.avcplus.p2p:111 max-temp-layer-p2p=3
a=rtpmap:109 H264/90000
a=fmtp:109 profile-level-id=42801f; max-br=20010; sar=13
a=vnd.polycom.avcplus.p2p:109 max-temp-layer-p2p=3
a=rtpmap:110 H264/90000
a=fmtp:110 profile-level-id=42801f; packetization-mode=1; max-br=20010; sar=13
a=vnd.polycom.avcplus.p2p:110 max-temp-layer-p2p=3
a=rtpmap:96 H263-1998/90000
a=fmtp:96 CIF4=1;CIF=1;QCIF=1;SQCIF=1;CUSTOM=352,240,1;CUSTOM=704,480,1;CUSTOM=1024,768,1;CUSTOM=800,600,1;CUSTOM=640,480,1;T
a=rtpmap:34 H263/90000
a=fmtp:34 CIF4=1;CIF=1;QCIF=1;SQCIF=1
a=rtpmap:31 H261/90000
a=fmtp:31 CIF=1;QCIF=1
a=rtpmap:106 H264-SVC/90000
a=fmtp:106 profile-level-id=56001f; packetization-mode=1; max-br=20010; sar=13
a=rtpmap:105 H264-SVC/90000
a=fmtp:105 profile-level-id=53e01f; packetization-mode=1; max-br=20010; sar=13
a=rtpmap:116 vnd.polycom.lpr/9000
a=fmtp:116 V=2;minPP=0;PP=150;RS=52;RP=10;PS=1400
m=application 3238 UDP/BFCP *
a=sendrecv
a=setup:actpass
a=connection:new
a=floorctrl:c-s
m=application 3236 RTP/AVP 100
a=sendrecv
a=rtpmap:100 H224/4800

Description

Reference issue

Fixes #...

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.67%. Comparing base (2edc074) to head (e1897fb).

Files Patch % Lines
unmarshal.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   64.67%   64.67%           
=======================================
  Files          12       12           
  Lines        1571     1571           
=======================================
  Hits         1016     1016           
  Misses        454      454           
  Partials      101      101           
Flag Coverage Δ
go 64.67% <0.00%> (ø)
wasm 64.67% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Great work @FizikRoot I would love to accept this change.

Would you mind adding a unit test?

@FizikRoot FizikRoot force-pushed the patch-1 branch 2 times, most recently from 051b715 to 75e97e4 Compare March 28, 2023 11:29
@FizikRoot
Copy link
Contributor Author

Add avoid exception when read Cisco SDP with CUBE

v=0
o=tandberg 4 1 IN IP4 192.168.1.248
s=-
c=IN IP4 192.168.1.253
b=AS:1920
t=0 0
a=cisco-mari-rate
m=application 2455 UDP/UDT/IX *
a=ixmap:0 ping
a=ixmap:2 xccp

@Sean-Der Sean-Der merged commit 84cf380 into pion:master Mar 28, 2024
13 of 14 checks passed
@Sean-Der
Copy link
Member

Oof I am really sorry how long this took @FizikRoot merging now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants