Remove unused member in SCTPTransport

RTOMax wasn't actually being stored, is being pulled directly from SettingEngine
pion · Mar 18, 2024 · 5d7c2bf · 5d7c2bf
1 parent 313ca8c
commit 5d7c2bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/sctptransport.go b/sctptransport.go
@@ -58,8 +58,6 @@ type SCTPTransport struct {
 
 	api *API
 	log logging.LeveledLogger
-	// maximum retransmission timeout
-	rtoMax float64
 }
 
 // NewSCTPTransport creates a new SCTPTransport.
@@ -107,13 +105,12 @@ func (r *SCTPTransport) Start(SCTPCapabilities) error {
 	if dtlsTransport == nil || dtlsTransport.conn == nil {
 		return errSCTPTransportDTLS
 	}
-	rtoMax := float64(r.api.settingEngine.sctp.rtoMax) / float64(time.Millisecond)
 	sctpAssociation, err := sctp.Client(sctp.Config{
 		NetConn:              dtlsTransport.conn,
 		MaxReceiveBufferSize: r.api.settingEngine.sctp.maxReceiveBufferSize,
 		EnableZeroChecksum:   r.api.settingEngine.sctp.enableZeroChecksum,
 		LoggerFactory:        r.api.settingEngine.LoggerFactory,
-		RTOMax:               rtoMax,
+		RTOMax:               float64(r.api.settingEngine.sctp.rtoMax) / float64(time.Millisecond),
 	})
 	if err != nil {
 		return err

diff --git a/settingengine.go b/settingengine.go
@@ -434,7 +434,7 @@ func (e *SettingEngine) SetSCTPMaxReceiveBufferSize(maxReceiveBufferSize uint32)
 	e.sctp.maxReceiveBufferSize = maxReceiveBufferSize
 }
 
-// SetSCTPZeroChecksum enables the zero checksum feature in SCTP.
+// EnableSCTPZeroChecksum controls the zero checksum feature in SCTP.
 // This removes the need to checksum every incoming/outgoing packet and will reduce
 // latency and CPU usage. This feature is not backwards compatible so is disabled by default
 func (e *SettingEngine) EnableSCTPZeroChecksum(isEnabled bool) {