SampleBuilder: Remove deprecated functions #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 76.42% 76.39% -0.03%
==========================================
Files 87 87
Lines 9928 9919 -9
==========================================
- Hits 7587 7578 -9
Misses 1870 1870
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
at-wat
force-pushed
the
samplebuilder/remove-PopWithTimestamp
branch
from
a92fa8c
to
8da0197
Compare
|
This was referenced Feb 29, 2024
Use Sample.PacketTimestamp field instead. Migration example: - sample, timestamp := s.PopWithTimestamp() + sample := s.Pop() + timestamp := sample.PacketTimestamp BREAKING CHANGE: SampleBuilder.PopWithTimestamp method is removed
at-wat
force-pushed
the
samplebuilder/remove-PopWithTimestamp
branch
from
8da0197
to
80d13cd
Compare
at-wat
changed the title
Deprecated by #1928 BREAKING CHANGE: samplebuilder.WithPartitionHeadChecker option is removed.
tmatth
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample returned by
Pop()containsPacketTimestampfield now, soPopWithTimestamp()is redundant.As we're now preparing v4, it's good time to remove it.
Use Sample.PacketTimestamp field instead.
Migration example:
SampleBuilder: Remove WithPartitionHeadChecker
Deprecated by #1928