Adapt the samplebuilder to the new version of the depacketizer. #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jech
force-pushed
the
consistent-depacketizer
branch
4 times, most recently
from
457e473
to
80d718d
Compare
Sean-Der
force-pushed
the
consistent-depacketizer
branch
from
80d718d
to
bbf306d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
+ Coverage 75.55% 75.77% +0.22%
==========================================
Files 85 85
Lines 6123 6121 -2
==========================================
+ Hits 4626 4638 +12
+ Misses 1101 1092 -9
+ Partials 396 391 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sean-Der
force-pushed
the
consistent-depacketizer
branch
2 times, most recently
from
1281197
to
23a436c
Compare
Both partition head and tail checking is now done in the depacketizer. For backwards compatibility, there are stubs for PartitionHeadChecker and WithPartitionHeadChecker that do nothing; these should be removed for 4.0. This also fixes a bug with the depacketizer: if no head checker was present, every packet would be considered as a potential partition head, even if it was at the beginning of the buffer. Since a partition head checker is now always present, the bug cannot happen. The tests assume the old bug, which is why the fakePacketizer returns true if headBytes is empty. It would be better to adapt the tests to do the right thing, as in jech/depacketizer.
Sean-Der
force-pushed
the
consistent-depacketizer
branch
from
23a436c
to
0db6cb8
Compare
Sean-Der
approved these changes
Aug 23, 2021
at-wat
added a commit
that referenced
this pull request
Mar 4, 2024
Deprecated by #1928 BREAKING CHANGE: samplebuilder.WithPartitionHeadChecker option is removed.
at-wat
added a commit
that referenced
this pull request
Mar 14, 2024
Deprecated by #1928 BREAKING CHANGE: samplebuilder.WithPartitionHeadChecker option is removed.
ourwarmhouse
added a commit
to ourwarmhouse/store-backend-go
that referenced
this pull request
May 1, 2024
Deprecated by pion/webrtc#1928 BREAKING CHANGE: samplebuilder.WithPartitionHeadChecker option is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to pion/rtp#150 and #1882.
Also fixes a bug in the depacketizer: if there was no PartitionHeadChecker, the depacketizer would treat every packet as a potential partition head, even if it was at the beginning of the buffer. Since I didn't want to tweak the tests to account for the fixed bug, I simply had the head checker return true if headBytes is nil. Ideally, the tests should be fixed to do the right thing, which I have done in https://github.com/jech/depacketizer