Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SampleBuilder: Deprecate PopWithTimestamp #2686

Merged
merged 1 commit into from
Mar 14, 2024
Merged

SampleBuilder: Deprecate PopWithTimestamp #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/media/samplebuilder/samplebuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@
// PopWithTimestamp compiles pushed RTP packets into media samples and then
// returns the next valid sample with its associated RTP timestamp (or nil, 0 if
// no sample is compiled).
//
// Deprecated: PopWithTimestamp will be removed in v4. Use Sample.PacketTimestamp field instead.
func (s *SampleBuilder) PopWithTimestamp() (*media.Sample, uint32) {
sample := s.Pop()
if sample == nil {
Expand Down Expand Up @@ -338,7 +340,7 @@

// WithPartitionHeadChecker is obsolete, it does nothing.
func WithPartitionHeadChecker(interface{}) Option {
return func(o *SampleBuilder) {

Check warning on line 343 in pkg/media/samplebuilder/samplebuilder.go

View workflow job for this annotation

GitHub Actions / lint / Go 

unused-parameter: parameter 'o' seems to be unused, consider removing or renaming it as _ (revive)
}
}

Expand Down
Loading