[WIP] Fix race in DataChannel.open() #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enobufs
changed the title
enobufs
changed the title
Pull Request Test Coverage Report for Build 2476
💛 - Coveralls |
Sean-Der
reviewed
Mar 10, 2019
| @@ -182,12 +182,12 @@ func (d *DataChannel) open(sctpTransport *SCTPTransport) error { | |||
|
|
|||
| dc, err := datachannel.Dial(d.sctpTransport.association, *d.ID, cfg) | |||
| if err != nil { | |||
| d.mu.RUnlock() | |||
| d.mu.Unlock() | |||
| return err | |||
| } | |||
|
|
|||
| d.ReadyState = DataChannelStateOpen | |||
There was a problem hiding this comment.
Can you make this so we just take the writelock for setting d.ReadyState I just don't want to be wasteful having a write lock for the whole function. If this is a bad idea please push back!
d.mu.RUnlock()
d.mu.Lock()
d.ReadyState = DataChannelStateOpen
d.mu.Unlock()
There was a problem hiding this comment.
I think, it wouldn't give us much because:
- This method would virtually 100% succeed in production use (write lock will be held in most of times).
- Sticking with only one kind of lock is relatively less error-prone.
- DataChannel.open() won't be called that often anyway (I wouldn't worry)
There was a problem hiding this comment.
A agree with all that, I was overthinking it. More complicated code for no real gain :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it uses write lock in this PR.
No regression in unit tests, race detection nor golangci-lint in my local run.
I noticed the was a race (reported as #509), not caused by this modification.
Resolves #505