Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment fixes 2 #3052

Merged

Conversation

johnbartholomew
Copy link
Contributor

Fix for #3049

(I may add fixes for other equipment bugs later on)

It might need to be re-introduced in the future to call some combination
of UpdateEquipStats, UpdateLuaStats and UpdateFuelStats, but for now it's
better to call UpdateEquipStats directly to avoid confusion.
@johnbartholomew
Copy link
Contributor Author

Fix for #3049 updated. Fix for #3027 added.

@walterar
Copy link
Contributor

👍
Only one small detail:
The function "Ship:AddEquip" has changed its interface or is deprecated. The call originated at <[T] @ui/StationView/ShipMarket.lua:110>.

@johnbartholomew
Copy link
Contributor Author

Deprecation warnings fixed, and I have updated the documentation comments in data/libs/Ship.lua.

@walterar
Copy link
Contributor

brilliant

@walterar
Copy link
Contributor

Brillant * 2 :)

@johnbartholomew
Copy link
Contributor Author

Added fix for some actions producing negative "free space". For example, it was previously possible to scoop more cargo than you had space for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants