Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CMake. #4465

Merged
merged 5 commits into from
Nov 22, 2018
Merged

Switch to CMake. #4465

merged 5 commits into from
Nov 22, 2018

Conversation

Web-eWorks
Copy link
Member

@Web-eWorks Web-eWorks commented Oct 4, 2018

This PR (partially) resolves (github u no close) #4461, by moving travis builds to CMake over autotools.

We're still using the thirdparty repo for travis - is that needed? It would shave a good 5-10 minutes off our already lengthy compile times if we were to drop it.

Additionally, this PR fixes #4466.

@Web-eWorks Web-eWorks force-pushed the cmake-switch branch 3 times, most recently from 602f052 to 4738192 Compare October 5, 2018 16:55
@Web-eWorks Web-eWorks mentioned this pull request Oct 5, 2018
@Web-eWorks Web-eWorks force-pushed the cmake-switch branch 4 times, most recently from 48302d0 to b8e2b81 Compare October 5, 2018 19:59
@Web-eWorks
Copy link
Member Author

So I got most of this to work, but travis apparently has some issues that no-one else is experiencing. I estimate a few more commits before this is ready to merge.

@laarmen
Copy link
Contributor

laarmen commented Oct 29, 2018

Just a heads up, there are conflicts plus a travis build fail.

I'm not against using CMake as a default build system, but I'd rather keep the autotools around for a bit longer, just to be sure we're not breaking anybody's setup (everybody doesn't follow the github project and simply pull regularly from master).

Thanks for the hard work on the issue!

@Web-eWorks
Copy link
Member Author

Web-eWorks commented Nov 5, 2018

@laarmen thanks for the report. I plan on keeping autotools in a deprecated state for a while before we remove it outright.

I think I may have a solution to the latest round of errors, so this might actually be ready for a merge soon.

...I think.

@Web-eWorks
Copy link
Member Author

Huzzah, huzzah! It builds! Finally, everything works again.
@impaktor: pending a quick review (and maybe a squash), this PR is ready to merge. The deploy script needs updating to use the new binary location, but I'll take care of that when we add the API key.

@impaktor
Copy link
Member

impaktor commented Nov 6, 2018

I'm without pioneer-computer for the rest of this week, so I can't test it, but if @fluffyfreak and @ecraven, who are the main guys working on the C++ source the past year(s), are happy, then so am I (assuming squash 😄).

@impaktor
Copy link
Member

So we already have cmake in master, right? So this moves travis to also use cmake as well, and fixes the aforementioned bug? Is there anything for us to test? If not, we could merge now-ish, or by the weekend at the latest.

@Web-eWorks
Copy link
Member Author

@impaktor This just makes Travis build with CMake instead of autotools, updates the CMakefile so that we can build with thirdparty, and restores compatibility with versions of CMake < 3.12. It is ready to merge now, if you wish.

@impaktor impaktor merged commit a1a377a into pioneerspacesim:master Nov 22, 2018
@Web-eWorks Web-eWorks deleted the cmake-switch branch February 16, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake method failure
3 participants