-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PiGui Station Lobby view #4651
PiGui Station Lobby view #4651
Conversation
8aa0d34
to
ac0f8a7
Compare
After a quick check I noticed that the lobby window is empty when there is no hyperdrive. (Start at Barnard's Star) |
ac0f8a7
to
41dec86
Compare
Well, that was a stupid place to put a null check... that wasn't even necessary to begin with. Thanks for testing! Fixed. |
f804b7b
to
52e2bfa
Compare
Hey @impaktor, I'm almost done with the Commodity Market as well. Should I keep opening PRs, or is it better to merge everything uder one? |
I dunno. Who's feeling up to reviewing this? @Web-eWorks, @ecraven ? what do you guys prefer? At least, don't stop development, keep hacking away, on a new branch out of this PR's branch, I guess?, we can always cherry pick commits, or merge stuff, but if the Commodity market shares dependencies with thei PR, ideally we should test and merge this ASAP. I don't have any pioneer/internet time until next week, sorry. |
PiGui Image widget Fixed old Gui blinking-in the first tab of tab-views
52e2bfa
to
834253b
Compare
Done, I rebased your branch into mine |
Takes into account @mike-f1 hyperspace range fix from #4650
Was branched from #4624, so it also contains it's commits
EDIT: Will also close #4545