Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Avoid libGLU dependency #4994

Merged
merged 1 commit into from
Nov 3, 2020
Merged

CMake: Avoid libGLU dependency #4994

merged 1 commit into from
Nov 3, 2020

Conversation

pcercuei
Copy link
Contributor

@pcercuei pcercuei commented Nov 3, 2020

Set the GLEW_NO_GLU build flag to avoid pulling in <gl/glu.h> when
including <gl/glew.h>, as it otherwise adds a dependency we don't
actually need.

@pcercuei
CMake: Avoid libGLU dependency
9352dcb 
Set the GLEW_NO_GLU build flag to avoid pulling in <gl/glu.h> when
including <gl/glew.h>, as it otherwise adds a dependency we don't
actually need.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
The-EG
The-EG approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@The-EG The-EG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be an issue with Windows at all, but I tested compiling it anyway.

Both the cmake and solution built and ran; the fickle MSVC gods are still satisfied...for now...

@Web-eWorks Web-eWorks merged commit 200b52b into pioneerspacesim:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-EG The-EG The-EG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcercuei @The-EG @Web-eWorks