SystemView Atlas Mode #5239
SystemView Atlas Mode #5239
Conversation
|
Very nice! I know it's been discussed before to replace our mixed-resolution atlas objects with toy icons, but I think these mini-pictures really adds a sense of feeling for a system. Only problem is the "mini" part. I was curious what would hapen if one tried some "deep learning" to do image upscaling (result is not that good, but showing it anyway) : Example starOriginal: Example planet - (Fail?)Not so good example: Original: |
|
The ideal plan is to simply render the same body objects we use for the world view - that is, actual stars and planets - at small sizes in the system view for both orrery (orbit mode) and atlas body images. This would mean you can plan your landing site from the SystemView, and means that the bodies you see in the system view match what you'll see in the system when you get there. However, this is rather impractical at the moment because all of the code actually responsible for drawing a body is very tied to the world view and viewing the body from the perspective of a ship many millions of km away, and would need to be significantly refactored to produce good results in the SystemView. Also... we'd need to actually make our planets and stars look at least half as good as the icons do in both the SystemView and the world view for this to be a viable replacement. |
|
just to remember #4473 |
|
Some good/better results of image upscaling on the dev forum: |
|
I know, this is work in progress, hope you are open for a little test report (It's not written to tell you did bad work!): Nice first screenshot from Web-eWorks to present the new wiev - but this is what I have seen first:
So next task for the player is to reach the overview Web-eWorks has presented. To zoom with the mouse wheel works well, but how to move the display? Click, hold and drag ... no. Aaaah, first press the hold down to rotate view button! Improvement Suggestions:
Next thing i had a look on was the grid display mode. It can not be switched off in Atlas view, i also got no idea what could be the use of it there, and when you come back from another star system, it can be displayed even somewhere outside:
Suggestion:
Now let's play a little bit: Carry a package to one of the numerous orbital starports in the Gliese 667 system. So let's look where this orbital starport is - nowhere?
Aha, no orbital starports there (any more), so it must be on ground, checking all planets for a starport ... looking for information ... no, no information about starports available. Suggestion/Fix:
This is important to hyperjump to the right star (Gliese 667 A, B, or C) Anyway ... great work you do! |
|
Not sure I'd agree to remove grid. It highlights that the player is in "atlas mode", and watching a toy-representation of the system, where things are not to scale, relative each other (at least not distances). |
|
Why do we need to zoom in on the planets very much, imho the meaning of this view is to see on one screen what the system is like? |
|
Do you plan a stable version for next February? If yes, it could be good to have a master branch who can be tested by playing (during Christmas time) - but to play without system view requires annoying research for stations in systems you are not familiar with. Concerning grid: No distance function in Atlas view (so no need for) - and no scale in system map (1 AU in our solar system, but elsewhere?) Another bug found in the sector map: Star systems cannot be selected by just clicking on them (you have to use the search window and there, you can click on the name for the system being selected) There is also a grid in the sector map - without scale, without switch grid mode button, and without documented orientation? (assumed year 2000 celestial equator, of course good for today's players, but remember earth's precession) And I think, System Atlas should get back it's button at the top row (unless you integrate all maps in one button there) A completely other way we could go: The overview window (when flying) is added/integrated to the left side of the system map, it can be used as Atlas as well, it even displays distances yet! |
@Bodasey it's funny you mention that - that's already been done and dusted in one of my development branches, it's just been waiting for this branch to be finished before I PR it in! |
|
I'd say bring your "dust" to master via a separate PR for playability sooner - the illustrated atlas can wait. Or is it here yet, ready to be tested? The files I see here are dated Aug 11. |
Web-eWorks
force-pushed
the
systemview-atlas
branch
from
75b13d7
to
9ed42f0
Compare
Patience good sir! All will be done in good time, but do remember that the developers still working on the project have their own jobs and lives which take priority over Pioneer development time. I do appreciate your willingness to test, but the time it takes to disentangle the overview window from its dependency on this and other work branches is time much better spent finishing this PR. Speaking of which, I've been able to put some work in on this branch today; label drawing, body selection, and the layout of most systems have been massively improved. There's a bit more fundamental layout work needed on this branch (size reporting for layouts, better framing of system contents, etc), but it's getting close to a viable replacement of the old SystemInfoView and a point where I'd be happy to merge the branch in. Some screenshots: Now to address some of the feedback raised here:
The display is panned using the middle mouse button, which is the same across the world view, the system orrery view, and the system atlas view.
The trio of buttons on the right side apply only to the orrery view; they will likely be hidden when in the atlas view.
...Gliese 667 has no starports. I checked. Twice.
I would like to do this, but it requires a further refactor of the way the Projectable system works for displaying bodies in both the system views, which I do not have time for at this junction.
This is working correctly for me, not sure what you're doing. |
|
Web-eWorks, please don't feel chased - and please excuse me if you feel so.
Had starports in #4473 and because it has been mentioned there, has become a test object assuming the starports or something else are still there. There was no transport commission on a bulletin board. (btw, #4473 is still not on the list of bugs fixed wit this PR) |
|
A short test report:
not observed any more
pioneerwiki (read only?) says right mouse button, I expected left one - what if there is no middle mouse button/wheel? some things to improve:
known: many satellites cross
Overlaps can be in a way so that one object is not accessible any more, in this case Ethzelia C although displayed in foreground. It may be a fine idea to keep closely bound stars tight together also in the Atlas view, but then the right ones have to stay together (A/B and C/D, displayed are A/C and B/D). And the planets of the deselected star have to go in a darkened background.
Same as above |
|
tried - no edit field found... |
|
@Bodasey sounds strange, do you have a link? (you must login to the wiki to edit) |
- Hover to show labels next to systemview icons - Fix for uninitialized variable warnings - Drawables::Disk now generates UVs as well - Spruce up the atlas view with a background and zoom functionality
- Adjust star and planet perceptual sizes. - Add a detailed display of system body information
Single-click to select and deselect objects in system map view. Double-click to zoom to selected or reset viewpoint. Fixes a few runtime bugs and expands the SystemView API. Added text shadow for object names in SystemMap.
- Add screen size to projectable groups - Render body names using offset and arrow - Improve font / layout of body labels in atlas view - Clean up view reset behavior - Add icon indicator for body selection - Improve initial layout for most systems (Trinary+ star systems are still borked.)
Switch from single-pass algorithm to two-pass layout + render approach. This is overall cheaper, and produces much better results in complex systems. The algorithm could be tuned further, but I have no plans to do so in the near future. Add an operator[] and vector / vector overloads to vector2.h
Web-eWorks
force-pushed
the
systemview-atlas
branch
from
9ed42f0
to
b971eb4
Compare
|
no time for a deep test at the moment, only found time to download and compile - twice: @nozmajner Please be prepared to update kanara model files also if this error keeps on CreateCollisionMesh for : (kanara) with assimp5 while starting a new game |
|
@Bodasey you are the first person to my knowledge in multiple years to have issues loading these model files, and we've had people playing with all versions of assimp from 3-5. This is not a problem with the mesh files themselves, they have not changed in years and you are the only person to report this error - I'd recommend checking Pioneer out to a completely different part of your filesystem (make a directory in I would like to resolve the issue that is causing you to have errors loading models, but I can't currently allocate time to trying to reproduce a problem that no one else has ever encountered. As an alternative, you can clean the SGM model cache files and rebuild them ( Other than that, if no one encounters an error with this branch I'm going to merge it ~Thursday and open a PR with the system body list window. |
|
Info keeps displaying data from a system looked to before Overlaps: still happen, but everything is accessible played a while - no errors / crashes occurred
But the assimp package changed. Don't worry too much about this - i just observe and post what i see. Save the model files in an actual format should resolve this problem. |
Properly track gravpoint radius parameter to avoid layout overlaps. Clear the selected object when the active system changes.
Fixed. There should theoretically be no further edge-cases with gravpoint handling to produce this behavior. Also fixed the object label mouseover popup opening when under another window. Going to merge this now, I've spent long enough on this code and any further hidden warts can be addressed another time. |
|
Hooray! Great work @Web-eWorks and thanks @Bodasey for testing it! |
This PR reimplements the SystemInfoView as an Atlas display mode for the SystemView, similar to Elite: Dangerous' system map screen. It leverages the existing info box of the SystemView to display detailed information about a stellar body, and has a layout algorithm that produces (mostly) good results.
There are still several issues to be resolved; label positioning relative to the body and selection/interaction are two major glaring issues, as are several corner-case bugs with the layout algorithm in systems containing excessive amounts of gravpoints, like the below.
New body icons would also be very nice to have for this PR, as they're rather... low resolution and not meant to be zoomed upon, as this new screen allows.
TODO List:
Add screen-effect shader to stellar backgroundCut from this release, can be picked up by others.Add centering / pan-to functionalityCut from this release, fairly trivial if one wants to walk the tree or add a cached offset value.Fixes #5236, fixes #2985, fixes #4473, fixes #5213, fixes #5308.