Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuelClub: Refuel internal fuel tank only once a day #5311

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

robothauler
Copy link
Contributor

Members get refueled every time and can sell the internal fuel over and over again.
This PR prevents that and limits the refilling to once a day after takeoff.

@impaktor
Copy link
Member

I think there should also be edits to the language file, so when you ask for the rules/contract there's a "we'll refuel you once per day", or similar, somewhere, where it's fitting.

@impaktor
Copy link
Member

impaktor commented Jan 3, 2022

If anyone has play tested this / tried to get it to break, please let us know.

I assume we're aiming for merging stuff for a February 3rd release again...

@Bodasey
Copy link

Bodasey commented Jan 3, 2022

played a little bit, found this:

  1. "refuel full" your tank in the station's lobby
  2. enter fuel foundation (or another fuel organization)
  3. pump down fuel to freight room
  4. enter fuel foundation again

=> no refill, the first call of the foundation has blocked the function yet, although no fuel has been transferred.

I assume the same behave when you come back from fuel scooping and like to sell hydrogen to the foundation (fuel scooping always fails in this branch from code heritage). It will fill the missing 0.xxx tons when you first enter the fuel foundation as you can only transfer integer amounts to the tank.

I thought further to block automatic refuel function if a tank has less than 3% / 3t or so capacity left, but then you maybe want to force refueling when your tank is small, so you need a button for this...

...but if you add a button there anyway, you can directly call it "free tank refill for today" and skip the automatic background function.

@Bodasey
Copy link

Bodasey commented Jan 5, 2022

fine work, nothing found

(maybe a one-time cheat when a game from certain earlier versions is loaded, but once you save in this version, it's safe, i'd say there is no need for more code to prevent this single event)

What about #5282? There is still some possibility for arbitrage, but the quantities are very limited now. The clubs still don't accept taking back more waste than military fuel sold, i tested this also.

@Web-eWorks Web-eWorks merged commit f2783d0 into pioneerspacesim:master Jan 10, 2022
@robothauler robothauler deleted the refuel branch January 10, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants