Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): standalone CLI with better UX #71

Merged
merged 19 commits into from
Dec 14, 2023
Merged

feat(cli): standalone CLI with better UX #71

merged 19 commits into from
Dec 14, 2023

Conversation

pionxzh
Copy link
Owner

@pionxzh pionxzh commented Dec 10, 2023

closes #70
closes #62



image

Copy link

vercel bot commented Dec 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wakaru ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 7:10pm

@pionxzh pionxzh changed the title feat(cli): implement new standalone CLI with better UX feat(cli): standalone CLI with better UX Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3a314e0) 86.12% compared to head (6f94ef5) 88.23%.

Files Patch % Lines
packages/unminify/src/index.ts 0.00% 2 Missing ⚠️
packages/unminify/src/transformations/index.ts 0.00% 2 Missing ⚠️
packages/ast-utils/src/wrapStringTransformation.ts 94.44% 1 Missing ⚠️
packages/unminify/src/cli.ts 0.00% 1 Missing ⚠️
packages/unpacker/src/cli.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   86.12%   88.23%   +2.11%     
==========================================
  Files          92       93       +1     
  Lines       11566    11307     -259     
  Branches     1518     1519       +1     
==========================================
+ Hits         9961     9977      +16     
+ Misses       1557     1282     -275     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pionxzh
Copy link
Owner Author

pionxzh commented Dec 12, 2023

Moving to worker threads introduced a huge slowness. Will look into it.

@pionxzh
Copy link
Owner Author

pionxzh commented Dec 13, 2023

Interesting. Prettier is slower than I think.
image

@pionxzh
Copy link
Owner Author

pionxzh commented Dec 13, 2023

Improved the performance of prettier and lebab a bit.
image

@pionxzh pionxzh merged commit df455eb into main Dec 14, 2023
5 of 6 checks passed
@pionxzh pionxzh deleted the cli branch December 14, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize CLI to @wakaru/cli unminify CLI does not appy un-esm correctly
1 participant