Skip to content

Commit

Permalink
new: Unify add_files and add_files_recursive
Browse files Browse the repository at this point in the history
Since starting at the top of a directory tree and recursing within
that tree are now identical operations, there's no need for both
add_files and add_files_recursive.  This eliminates add_files (which
did nothing more than call add_files_recursive after the previous
patch) and renames add_files_recursive to add_files.
  • Loading branch information
Austin Clements authored and bremner committed May 25, 2012
1 parent da170ee commit 4ca3644
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions notmuch-new.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,9 @@ _entry_in_ignore_list (const char *entry, add_files_state_t *state)
* if fs_mtime isn't the current wall-clock time.
*/
static notmuch_status_t
add_files_recursive (notmuch_database_t *notmuch,
const char *path,
add_files_state_t *state)
add_files (notmuch_database_t *notmuch,
const char *path,
add_files_state_t *state)
{
DIR *dir = NULL;
struct dirent *entry = NULL;
Expand Down Expand Up @@ -377,7 +377,7 @@ add_files_recursive (notmuch_database_t *notmuch,
}

next = talloc_asprintf (notmuch, "%s/%s", path, entry->d_name);
status = add_files_recursive (notmuch, next, state);
status = add_files (notmuch, next, state);
if (status) {
ret = status;
goto DONE;
Expand Down Expand Up @@ -647,16 +647,6 @@ stop_progress_printing_timer (void)
}


/* This is the top-level entry point for add_files. It does a couple
* of error checks and then calls into the recursive function. */
static notmuch_status_t
add_files (notmuch_database_t *notmuch,
const char *path,
add_files_state_t *state)
{
return add_files_recursive (notmuch, path, state);
}

/* XXX: This should be merged with the add_files function since it
* shares a lot of logic with it. */
/* Recursively count all regular files in path and all sub-directories
Expand Down

0 comments on commit 4ca3644

Please sign in to comment.