Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work on https pages #26

Closed
Giorgi opened this issue Dec 25, 2019 · 5 comments
Closed

Does not work on https pages #26

Giorgi opened this issue Dec 25, 2019 · 5 comments

Comments

@Giorgi
Copy link
Contributor

Giorgi commented Dec 25, 2019

As the script is loaded from non https website it is blocked so can you configure your github pages website to use https?
@piotrl
Copy link
Owner

piotrl commented Jan 6, 2020 •
edited
Loading

Thanks for feedback, I'll try to configure it or migrate to HTTPS server :)

In fact it's shame I haven't done it yet.

@Giorgi
Copy link
Contributor Author

Giorgi commented Jan 6, 2020

It's very easy to configure and enforce it: Enforcing HTTPS for your GitHub Pages site

@piotrl
Copy link
Owner

piotrl commented Jan 6, 2020

I misconfigured some options in my domain provider panel. Updated them, will see again in 24 hours. :)

@piotrl
Copy link
Owner

piotrl commented Jan 7, 2020 •
edited
Loading

https://github-profile.com/ works fine now with https.

I'm going to update README with links soon with new default.

piotrl added a commit that referenced this issue Jan 7, 2020
@piotrl
#26 docs: update links to use HTTPS
02a5e18
piotrl added a commit that referenced this issue Jan 7, 2020
@piotrl
#26 docs: update links to use HTTPS
56664bf
@piotrl piotrl closed this as completed Jan 7, 2020
@Giorgi
Copy link
Contributor Author

Giorgi commented Jan 7, 2020

Thanks

piotrl added a commit that referenced this issue Jan 20, 2020
@piotrl
#26 chore: update missing http link to https
3149b87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piotrl @Giorgi