Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react version to v17 #1847

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Update react version to v17 #1847

merged 1 commit into from
Apr 12, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Apr 9, 2021

What this PR does / why we need it:

  • Update tsconfig, eslint config to support react v17
  • Update packages that dependent to React
  • Remove importing of React. See this link to more details.
    • I used npx react-codemod update-react-imports to replace current importing.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.86%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.36%. This pull request decreases coverage by -0.03%.

File Base Head Diff
src/components/stage-status-icon/index.tsx 84.62% 83.33% -1.28%
src/components/toasts/index.tsx 100.00% 100.00% +0.00%
test-utils.tsx 100.00% 100.00% +0.00%
src/components/application-list/index.tsx 90.20% 90.38% +0.19%
src/components/deployment-config-form/index.tsx 90.32% 90.62% +0.30%
src/components/deployment-status-icon/index.tsx 100.00% 100.00% +0.00%
src/components/kubernetes-resource-detail/index.tsx 75.00% 71.43% -3.57%
src/components/split-button/index.tsx 100.00% 100.00% +0.00%
src/components/app-sync-status/index.tsx 100.00% 100.00% +0.00%
src/components/log-line/index.tsx 100.00% 100.00% +0.00%
src/components/project-setting-labeled-text/index.tsx 100.00% 100.00% +0.00%
src/components/sync-status-icon/index.tsx 83.33% 81.82% -1.52%
src/pages/login.tsx 84.00% 84.62% +0.62%

@cakecatz cakecatz changed the title WIP: Update react version to v17 Update react version to v17 Apr 9, 2021
@nghialv
Copy link
Member

nghialv commented Apr 12, 2021

/lgtm

@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit fa31a17 into master Apr 12, 2021
@pipecd-bot pipecd-bot deleted the update-react branch April 12, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants