Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web API to return the real data of application counts #1990

Merged
merged 2 commits into from May 24, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented May 21, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Cache application counts in the cache service.

https://github.com/pipe-cd/pipe/blob/0c4ff7e5dbbca3abd0ff190933aec4b7cdc32c5a/pkg/app/api/grpcapi/web_api.go#L1465-L1468

This was created by todo plugin since "TODO:" was found in 0c4ff7e when #1990 was merged. cc: @nghialv.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.93%. This pull request increases coverage by 0.07%.

File Function Base Head Diff
pkg/app/api/grpcapi/web_api.go WebAPI.GetInsightApplicationCount 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/applications.go Collector.updateApplicationCounts 0.00% 0.00% +0.00%
pkg/insight/applicationcount.go MakeApplicationCounts 0.00% 100.00% +100.00%

@khanhtc1202
Copy link
Member

🚀
/lgtm

@nakabonne
Copy link
Member

🤒
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants