Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaskSetDefinition as required configuration for ECS deployment #2021

Merged
merged 1 commit into from May 28, 2021

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2011

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Support loading TaskSetDefinition file with JSON format

https://github.com/pipe-cd/pipe/blob/2e0e8d0ffe9c284389ecb95c09ebbaf432b247b5/pkg/app/piped/cloudprovider/ecs/taskset.go#L35-L38

This was created by todo plugin since "TODO:" was found in 2e0e8d0 when #2021 was merged. cc: @khanhtc1202.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.38%. This pull request decreases coverage by -0.28%.

File Function Base Head Diff
pkg/app/ops/handler/handler.go NewHandler -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.Run -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.run -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.stop -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleTop -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleListProjects -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleAddProject -- 0.00% +0.00%
pkg/app/ops/handler/handler.go Handler.handleApplicationCounts -- 0.00% +0.00%
pkg/app/ops/handler/handler.go groupApplicationCounts -- 100.00% +100.00%

@nakabonne
Copy link
Member

Nice
/lgtm

@nghialv
Copy link
Member

nghialv commented May 28, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find better way to get those 2 values instead of set it via service def.
4 participants