Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send remaining notification events before exiting and fix env name #543

Merged
merged 3 commits into from Jul 27, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 27, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jul 27, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

pkg/app/piped/notifier/webhook.go Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Support application type of notification event.

https://github.com/pipe-cd/pipe/blob/a06fe8325a2a091c0b12e22a2d45fc779febc7de/pkg/app/piped/notifier/slack.go#L203-L206

This was created by todo plugin since "TODO:" was found in a06fe83 when #543 was merged. cc: @nghialv.

@nghialv nghialv merged commit 097e014 into master Jul 27, 2020
@pipecd-bot pipecd-bot deleted the notification branch July 27, 2020 16:18
@nghialv
Copy link
Member Author

nghialv commented Jul 27, 2020

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.1.9

Notable Changes

No notable changes for this release

Internal Changes

  • Send remaining notification events before exiting and fix env name (#543)
  • Add GetEnvironment rpc to piped api (#542)
  • Set the commander by the logged in username (#541)
  • Fix image tag for push-site-image build (#540)
  • Show user avatar if user is logged in (#539)
  • Fixed grpc api path (#538)
  • Added missing authorization conditions (#537)
  • Removed code that verifies jwt temporarily (#533)
  • Add ability to send notifications to slack (#531)
  • Fix push-site-image build to keep git clean (#530)
  • Add fetching user info to the first loading (#529)
  • Add guide to run website locally to README.md (#528)
  • Ensure to order lists by UpdatedAt (#527)
  • Refactor documentation and website (#526)
  • Update README.md for examples (#525)
  • Add README for examples repository (#524)
  • Update image tag for examples (#523)
  • Build site image when merged (#522)
  • Rename documentation files (#521)
  • Add examples (#520)
  • Add documentation and site (#519)
  • Fix application detail layout (#518)
  • Implemented GetMe API (#510)

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.58%. This pull request decreases coverage by -0.12%.

File Function Base Head Diff
pkg/app/piped/apistore/environmentstore/store.go NewStore -- 0.00% +0.00%
pkg/app/piped/apistore/environmentstore/store.go Store.Get -- 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.Close -- 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.sendEvent -- 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.buildSlackMessage -- 0.00% +0.00%
pkg/app/piped/notifier/webhook.go webhook.Close -- 100.00% +100.00%
pkg/model/event.go EventDeploymentTriggered.GetAppName -- 100.00% +100.00%
pkg/model/event.go EventDeploymentPlanned.GetAppName -- 0.00% +0.00%
pkg/model/event.go EventDeploymentApproved.GetAppName -- 0.00% +0.00%
pkg/model/event.go EventDeploymentRollingBack.GetAppName -- 0.00% +0.00%
pkg/model/event.go EventDeploymentSucceeded.GetAppName -- 0.00% +0.00%
pkg/model/event.go EventDeploymentFailed.GetAppName -- 0.00% +0.00%
pkg/model/event.go EventApplicationSynced.GetAppName -- 0.00% +0.00%
pkg/model/event.go EventApplicationOutOfSync.GetAppName -- 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.startNewPlanner 0.00% 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.startNewScheduler 0.00% 0.00% +0.00%
pkg/app/piped/notifier/notifier.go Notifier.Run 0.00% 0.00% +0.00%
pkg/app/piped/notifier/notifier.go Notifier.Notify 0.00% 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.Run 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%
pkg/app/piped/notifier/slack.go buildSlackMessage 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentTriggered.AppName 100.00% -- -100.00%
pkg/model/event.go EventDeploymentPlanned.AppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentApproved.AppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentRollingBack.AppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentSucceeded.AppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentFailed.AppName 0.00% -- +-0.00%
pkg/model/event.go EventApplicationSynced.AppName 0.00% -- +-0.00%
pkg/model/event.go EventApplicationOutOfSync.AppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentTriggered.EnvID 100.00% -- -100.00%
pkg/model/event.go EventDeploymentPlanned.EnvID 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentApproved.EnvID 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentRollingBack.EnvID 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentSucceeded.EnvID 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentFailed.EnvID 0.00% -- +-0.00%
pkg/model/event.go EventApplicationSynced.EnvID 0.00% -- +-0.00%
pkg/model/event.go EventApplicationOutOfSync.EnvID 0.00% -- +-0.00%

@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants