Make a login cookie insecure in quick start or debug case #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Make cookie secureThis was created by todo plugin since "TODO:" was found in 580fb34 when #736 was merged. cc: @nakabonne. |
|
/cc @gkuga |
|
Code coverage for golang is |
|
@gkuga Fixed! |
|
Code coverage for golang is |
gkuga
changed the title
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
failed to handle template rule examples Details |
This was referenced Sep 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For investigation #732
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: