-
Notifications
You must be signed in to change notification settings - Fork 135
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve UX of project SSO config form (#737)
**What this PR does / why we need it**: ![image](https://user-images.githubusercontent.com/6136383/92120533-26823900-ee34-11ea-8028-52f39dd0fcd4.png) ![image](https://user-images.githubusercontent.com/6136383/92120546-2aae5680-ee34-11ea-8967-c0455a756a6a.png) **Which issue(s) this PR fixes**: Fixes #718 **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
- Loading branch information
Showing
10 changed files
with
401 additions
and
200 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,9 @@ | ||
import React from "react"; | ||
import { GithubSSOForm } from "./github-sso-form"; | ||
import { action } from "@storybook/addon-actions"; | ||
|
||
export default { | ||
title: "SETTINGS/GithubSSOForm", | ||
component: GithubSSOForm, | ||
}; | ||
|
||
export const overview: React.FC = () => ( | ||
<GithubSSOForm | ||
onSave={(params) => { | ||
action("onSave")(params); | ||
return Promise.resolve(); | ||
}} | ||
isSaving={false} | ||
/> | ||
); | ||
export const overview: React.FC = () => <GithubSSOForm />; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import React from "react"; | ||
import { InputForm } from "./input-form"; | ||
import { action } from "@storybook/addon-actions"; | ||
|
||
export default { | ||
title: "InputForm", | ||
component: InputForm, | ||
}; | ||
|
||
export const overview: React.FC = () => ( | ||
<InputForm name="Name" currentValue="value" onSave={action("onChange")} /> | ||
); | ||
|
||
export const IsSecret: React.FC = () => ( | ||
<InputForm | ||
name="Name" | ||
currentValue="value" | ||
onSave={action("onChange")} | ||
isSecret | ||
/> | ||
); |
Oops, something went wrong.