Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate for RBAC config from SSO config form #718

Closed
cakecatz opened this issue Aug 27, 2020 · 1 comment · Fixed by #737
Closed

Separate for RBAC config from SSO config form #718

cakecatz opened this issue Aug 27, 2020 · 1 comment · Fixed by #737
Assignees
@cakecatz
Labels
area/web kind/enhancement New feature or request
Projects
ROADMAP

Comments

@cakecatz
Copy link
Contributor

What would you like to be added:

Why is this needed:

/assign @cakecatz
/label area/web
@cakecatz cakecatz added the kind/enhancement New feature or request label Aug 27, 2020
@project-bot project-bot bot added this to Future in ROADMAP Aug 27, 2020
@gkuga
Copy link
Contributor

gkuga commented Aug 28, 2020 •
edited

plz display the current configurations and make it possible to edit each configurations.

Teams
  Organization: org-name
  Admin: admin-team
  Editor: editor-team
  Viewer: viewer-team

GitHub SSO
  Client ID: client-id
  BaseURL #this can be empty unless GHE is not used.
  UploadURL #this can be empty unless GHE is not used.

@gkuga gkuga closed this as completed Aug 28, 2020
ROADMAP automation moved this from Future to DONE Aug 28, 2020
@gkuga gkuga reopened this Aug 28, 2020
@nakabonne nakabonne moved this from DONE to v1 - 2020/08/21 - 2020/09/30 in ROADMAP Sep 1, 2020
@cakecatz cakecatz changed the title Separate separate for RBAC config from SSO config form Separate for RBAC config from SSO config form Sep 2, 2020
@cakecatz cakecatz mentioned this issue Sep 3, 2020
Merged
ROADMAP automation moved this from v1 - 2020/08/21 - 2020/09/30 to DONE Sep 3, 2020
pipecd-bot pushed a commit that referenced this issue Sep 3, 2020
@cakecatz
Improve UX of project SSO config form (#737)
b00fe26 
**What this PR does / why we need it**:
![image](https://user-images.githubusercontent.com/6136383/92120533-26823900-ee34-11ea-8028-52f39dd0fcd4.png)

![image](https://user-images.githubusercontent.com/6136383/92120546-2aae5680-ee34-11ea-8967-c0455a756a6a.png)


**Which issue(s) this PR fixes**:

Fixes #718

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cakecatz cakecatz

Labels
area/web kind/enhancement New feature or request
Projects
No open projects
ROADMAP
  
DONE
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve UX of project SSO config form pipe-cd/pipecd
3 participants
@cakecatz @gkuga @pipecd-bot