Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use goyaml.Read() upon merging our patch #1531

Closed
pipecd-bot opened this issue Feb 2, 2021 · 0 comments · Fixed by #1534
Closed

Use goyaml.Read() upon merging our patch #1531

pipecd-bot opened this issue Feb 2, 2021 · 0 comments · Fixed by #1534
Assignees
@nakabonne
Labels
kind/todo

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/446feb85384cb12b0bc1592d990c26775b859ec2/pkg/yamlprocessor/yamlprocessor.go#L61-L64

This was created by todo plugin since "TODO:" was found in 446feb8 when #1529 was merged. cc: @nakabonne.
@nakabonne nakabonne mentioned this issue Feb 2, 2021
Merged
pipecd-bot pushed a commit that referenced this issue Feb 2, 2021
@nakabonne
Use goccy/go-yaml.Read instead of parsing ourselves (#1534)
a730a25 
**What this PR does / why we need it**:
Since goccy/go-yaml#194 has been merged and released, we can close #1531.

Besides, goccy/go-yaml#196 is soon-to-be-released, hence we can also close #1530.

**Which issue(s) this PR fixes**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nakabonne nakabonne

Labels
kind/todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use goccy/go-yaml.Read instead of parsing ourselves pipe-cd/pipecd
2 participants
@nakabonne @pipecd-bot