Fix to give back error when path not found #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipecd-bot
pushed a commit
to pipe-cd/pipecd
that referenced
this pull request
Feb 2, 2021
**What this PR does / why we need it**: Currently it panics if you give non-existence yaml-path to Event watcher. This is happing due to go-yaml's issue. So I sent a PR to fix them: goccy/go-yaml#194 Until merging it, I just settled on parsing an AST node ourselves as a workaround. **Which issue(s) this PR fixes**: Fixes #1470 **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
|
Thank you for the great PR ( and Issue ) ! Only one point, the error list is written here, can you add an error like |
|
Thank you for the quick response. Okay, let me do so. |
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 76.20% 76.20%
=======================================
Files 11 11
Lines 2937 2937
=======================================
Hits 2238 2238
Misses 468 468
Partials 231 231 |
|
@goccy I addressed it. PTAL 😄 |
|
Thank you for the contribution ! I will merge it ! |
pipecd-bot
pushed a commit
to pipe-cd/pipecd
that referenced
this pull request
Feb 2, 2021
**What this PR does / why we need it**: Since goccy/go-yaml#194 has been merged and released, we can close #1531. Besides, goccy/go-yaml#196 is soon-to-be-released, hence we can also close #1530. **Which issue(s) this PR fixes**: **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` This PR was merged by Kapetanios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
This is happening because
Path.Read()assumes it's going to have a non-nil Node if no error returned. But it could give back a nil Node even if no error was given.I little poked around the codebase and most of the callers of
Path.FilterFile()assume the same does.It would be great if you could give me any feedback.