-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show ECS traffic stage detail on web view #2082
Conversation
trafficRoutePrimaryMetadataKey = "primary-percentage" | ||
trafficRouteCanaryMetadataKey = "canary-percentage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the key name so that we can reuse the web view defined key name
ref: https://github.com/pipe-cd/pipe/blob/b72e1ca904b39251fd507a332efa109795458af6/pkg/app/web/src/components/pipeline-stage/index.tsx#L62-L67
Code coverage for javascript is
|
/lgtm |
/approve |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow PR #2077
Does this PR introduce a user-facing change?: