Add doc for plan-preview feature #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is |
nakabonne
reviewed
Jul 7, 2021
|
|
||
| ## Prerequisites | ||
|
|
||
| - Your Pipeds are running at least version `v0.11.0`. |
There was a problem hiding this comment.
nit but it's on you
Suggested change
| - Your Pipeds are running at least version `v0.11.0`. | |
| - Your Pipeds are greater than at least `v0.11.0`. |
There was a problem hiding this comment.
Let me change this to Ensure the version of your Piped is at least v0.11.0.
|
left a nit comment but mostly LGTM |
khanhtc1202
reviewed
Jul 7, 2021
|
|
||
| > NOTE: This feature is currently under Alpha status. | ||
|
|
||
| In order to help developers review the pull request with a better experience and more confidence to approve it to trigger the actual deployments, |
There was a problem hiding this comment.
Suggested change
| In order to help developers review the pull request with a better experience and more confidence to approve it to trigger the actual deployments, | |
| In order to help developers review the pull request with a better experience and more confidence to approve it and trigger the actual deployments, |
khanhtc1202
reviewed
Jul 7, 2021
|
|
||
| ## GitHub Actions | ||
|
|
||
| If you are using GitHub Actions, you can seamlessly integrate our prepared [actions-plan-preview](https://github.com/pipe-cd/actions-plan-preview) to your workflows. This automatically comments the plan-preview result on the pull request when it is opened or updated. You can also trigger to run plan-preview manually by leave a comment `/pipecd plan-preview` on the pull request. |
khanhtc1202
reviewed
Jul 7, 2021
Comment on lines
16
to
18
| - what application will be deployed once the pull request got merged | ||
| - what deployment strategy (QUICK_SYNC or PIPELINE_SYNC) will be used | ||
| - what resources will be added, deleted, or modified |
There was a problem hiding this comment.
nit, but up to you 🙆♀️
Suggested change
| - what application will be deployed once the pull request got merged | |
| - what deployment strategy (QUICK_SYNC or PIPELINE_SYNC) will be used | |
| - what resources will be added, deleted, or modified | |
| - which application will be deployed once the pull request got merged | |
| - which deployment strategy (QUICK_SYNC or PIPELINE_SYNC) will be used | |
| - which resources will be added, deleted, or modified |
|
Thank you. Applied them. |
|
Nice. Can't wait to see on our website |
|
Go go go 🎉 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: