Introducing pipedstat model

[khanhtc1202]

What this PR does / why we need it:

• Mark PipedStats model as deprecated
• Introduce PipedStat model which wraps piped stat data with timestamp value. The timestamp value will be used to filter out outdated piped stat on expose
• Remove TTLHashCache constructor, since we will not expire value of hashkey by the cache itself but make it in application layer (address it later).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

[pipecd-bot]

Some issues were detected while linting go source files in your changes.

[pipecd-bot]

Code coverage for golang is 31.68%. This pull request decreases coverage by -0.01%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.ReportStat	0.00%	0.00%	+0.00%

[pipecd-bot]

Code coverage for golang is 31.69%. This pull request decreases coverage by -0.00%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.ReportStat	0.00%	0.00%	+0.00%
pkg/app/ops/pipedstatsbuilder/builder.go	PipedStatsBuilder.Build	61.54%	58.82%	-2.71%
pkg/cache/rediscache/hashcache.go	NewTTLHashCache	0.00%	--	+-0.00%

[nghialv]

typo in the PR title

Intruducing

[nghialv]

How about adding PipedID into this message?
I know we are having that ID from the map key but ID inside its data could be helpful as well.

[khanhtc1202]

Sure 👍 Btw I'm thinking about the current model name, just want to make it PipedMetrics. In that case, PipedMetrics.PipedID and PipedMetrics.Stat looks better than PipedStat.PipedID and PipedStat.Stat as currently. Just wonder is that name too generics or something 🤔 How do you think about that?

[nghialv]

I think PipedMetrics is good too. But currently, our RPC name is Report...Stats, right?
So maybe we should keep that model name as PipedStat and change its Stat field to Metrics.
Or we can reuse the old PipedStats model, deprecate unused fields and add new fields like PipedID, Metrics.

[khanhtc1202]

So maybe we should keep that model name as PipedStat and change its Stat field to Metrics.

Get your point, lets me adopt this 👍 ( Personally don't think the name should be XXXStats since this message covers only a single value of piped committed stat at a time )

[khanhtc1202]

Addressed by ae07feb 🙏

[pipecd-bot]

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

---

1. Filter returning piped metrics by value timestamp.

https://github.com/pipe-cd/pipe/blob/ae07febc5c251a1f385208128da01fb9abe14aeb/pkg/app/ops/pipedstatsbuilder/builder.go#L60-L63

This was created by todo plugin since "TODO:" was found in ae07feb when #2261 was merged. cc: @khanhtc1202.

[khanhtc1202]

/todo skip

[nakabonne]

Cool
/lgtm

[nghialv]

/approve

[pipecd-bot]

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

[pipecd-bot]

Code coverage for golang is 31.69%. This pull request decreases coverage by -0.00%.

File	Function	Base	Head	Diff
pkg/app/api/grpcapi/piped_api.go	PipedAPI.ReportStat	0.00%	0.00%	+0.00%
pkg/app/ops/pipedstatsbuilder/builder.go	PipedStatsBuilder.Build	61.54%	58.82%	-2.71%
pkg/cache/rediscache/hashcache.go	NewTTLHashCache	0.00%	--	+-0.00%