Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing pipedstat model #2261
Introducing pipedstat model #2261
Changes from 2 commits
622f984
d827a28
b51873d
f47e845
ae07feb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding PipedID into this message?
I know we are having that ID from the map key but ID inside its data could be helpful as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 👍 Btw I'm thinking about the current model name, just want to make it PipedMetrics. In that case, PipedMetrics.PipedID and PipedMetrics.Stat looks better than PipedStat.PipedID and PipedStat.Stat as currently. Just wonder is that name too generics or something 🤔 How do you think about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
PipedMetrics
is good too. But currently, our RPC name isReport...Stats
, right?So maybe we should keep that model name as
PipedStat
and change itsStat
field toMetrics
.Or we can reuse the old
PipedStats
model, deprecate unused fields and add new fields likePipedID
,Metrics
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get your point, lets me adopt this 👍 ( Personally don't think the name should be
XXXStats
since this message covers only a single value of piped committed stat at a time )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed by ae07feb 🙏