-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply worker pool to speed up plan-preview's execution #2303
Conversation
Code coverage for golang is
|
0022aec
to
a0b6ee2
Compare
Code coverage for golang is
|
/changelog |
@nghialv: Changelog has been generated in response to this comment. DetailsChangelog since v0.13.1Notable Changes
Internal Changes
|
pkg/app/piped/planpreview/builder.go
Outdated
envName = env.Name | ||
} | ||
// Start some workers to speed up building time. | ||
b.logger.Info(fmt.Sprintf("start %d workers for building plan-preview results for %d applications", numWorkers, numApps)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use the above wrapped logger
? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Nice catch!
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use |
Code coverage for golang is
|
Nice work |
Good improvement |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2296
Does this PR introduce a user-facing change?: