Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the logic to find accounts in the specified event #2669

Merged
merged 1 commit into from Oct 21, 2021

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Oct 21, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.06%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/config/deployment.go DeploymentNotification.FindSlackAccounts -- 0.00% +0.00%
pkg/app/piped/controller/planner.go planner.getMentionedAccounts 0.00% 0.00% +0.00%
pkg/app/piped/controller/scheduler.go scheduler.getMentionedAccounts 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Oct 21, 2021

/lgtm

@nakabonne
Copy link
Member

👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d5623bc into master Oct 21, 2021
@pipecd-bot pipecd-bot deleted the refactor-getting-accounts branch October 21, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants