Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update slack mentions in examples #2671

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Update slack mentions in examples #2671

merged 6 commits into from
Oct 22, 2021

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Oct 21, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.06%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.06%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot added size/S and removed size/M labels Oct 22, 2021
@ono-max ono-max requested a review from nghialv October 22, 2021 00:33
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.06%. This pull request does not change code coverage.

@nghialv nghialv changed the title Add some examples Update slack mentions in examples Oct 22, 2021
@nghialv
Copy link
Member

nghialv commented Oct 22, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit a2f2c98 into master Oct 22, 2021
@pipecd-bot pipecd-bot deleted the add-some-example branch October 22, 2021 00:56
@nghialv
Copy link
Member

nghialv commented Oct 22, 2021

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.20.1

Notable Changes

No notable changes for this release

Internal Changes

  • Update slack mentions in examples (#2671)
  • Fix the typo (#2672)
  • Refactor the logic to find accounts in the specified event (#2669)
  • Add an admin HTTP server to launcher (#2667)
  • Store DeploymentNotification key instead of mentions (#2664)
  • Fix tiny changes (#2666)
  • Add Concepts page in Japanese to the document (#2646)
  • Avoid stacked toast of the same reason (#2665)
  • Enable share query url to non login user (#2663)
  • Refactor the logic of getting accounts in PLANNED event (#2641)
  • Ensure redirect to previous path after login (#2662)
  • Refactor the logic of getting accounts in APPROVAL events (#2642)
  • Refactor the logic of getting accounts when Deployment is done (#2643)
  • Enable using current username as default value for static admin edit form (#2661)
  • Pass query params on redirect non login user to login page (#2660)
  • Add log to clarify launcher loading piped config flow (#2659)
  • Refine bazel build file (#2658)
  • Add blog tab to japanese site (#2657)
  • Remove list deployment config template (#2656)
  • Fix missing initializing ecs store for livestate store (#2655)
  • Remove dependency on Firestore from Operators (#2654)

@pipecd-bot pipecd-bot mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ono-max @pipecd-bot @nghialv