Show label on the app detail and list page #3011

nakabonne · 2022-01-07T05:50:00Z

What this PR does / why we need it:
With it we can see labels on the application detail page as well as the application list page.

On the detail page:

On the list:

Which issue(s) this PR fixes:

Fixes #3009

Does this PR introduce a user-facing change?:

NONE

pipecd-bot · 2022-01-07T05:58:46Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

nakabonne · 2022-01-07T06:07:38Z

/trigger web-test

pipecd-bot · 2022-01-07T06:07:40Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

nakabonne · 2022-01-07T06:44:47Z

/trigger web-test

pipecd-bot · 2022-01-07T06:44:49Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

pipecd-bot · 2022-01-07T07:01:16Z

Code coverage for javascript is 81.87%. This pull request decreases coverage by -0.02%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	`96.55%`	`94.92%`	`-1.64%`

nakabonne · 2022-01-07T08:29:54Z

Updated to show them on the application list page as well.

pipecd-bot · 2022-01-07T08:36:02Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

pipecd-bot · 2022-01-07T08:45:31Z

Code coverage for javascript is 81.85%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	`96.55%`	`94.92%`	`-1.64%`
src/components/applications-page/application-list/application-list-item/index.tsx	`93.62%`	`91.67%`	`-1.95%`

nakabonne · 2022-01-07T09:41:46Z

Since we're looking into updating the Environment when adding a label that has env as a key
/hold

nakabonne · 2022-01-07T09:42:03Z

/hold

nakabonne · 2022-01-11T08:26:31Z

/rebase

pipecd-bot · 2022-01-11T08:26:38Z

@nakabonne: Rebased this pull request in response to this comment.

pipecd-bot · 2022-01-11T08:35:16Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

pipecd-bot · 2022-01-11T08:43:16Z

Code coverage for javascript is 81.82%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	`96.55%`	`94.92%`	`-1.64%`
src/components/applications-page/application-list/application-list-item/index.tsx	`93.62%`	`91.67%`	`-1.95%`

nakabonne · 2022-01-12T08:20:53Z

/hold cancel

nakabonne · 2022-01-12T08:22:47Z

The warning icon and header text couldn't be aligned. Let me correct it later.

pipecd-bot · 2022-01-12T08:28:16Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

pipecd-bot · 2022-01-12T08:37:16Z

Code coverage for javascript is 81.83%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	`96.55%`	`94.92%`	`-1.64%`
src/components/applications-page/application-list/index.tsx	`90.57%`	`90.74%`	`+0.17%`
src/components/applications-page/application-list/application-list-item/index.tsx	`93.62%`	`91.67%`	`-1.95%`

nghialv · 2022-01-12T08:51:40Z

pkg/app/web/src/components/application-detail-page/application-detail/index.tsx

@@ -217,6 +221,14 @@ export const ApplicationDetail: FC<ApplicationDetailProps> = memo(
                {env.name}
              </Typography>
            )}
+            {app?.labelsMap.map((label, i) => (
+              <Chip
+                label={label[0] + ":" + label[1]}


How about adding a space between the value and key as key: value?

For the app list page, you can't do that because the line breaks make it difficult to read. But for the detail page, looks nice:

Thank you. 👍

nghialv · 2022-01-12T09:30:23Z

Can't wait to see it. Great job!
/lgtm

pkg/app/web/src/components/applications-page/application-list/index.tsx

pipecd-bot · 2022-01-12T09:38:16Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

pipecd-bot · 2022-01-12T09:45:46Z

Code coverage for javascript is 81.83%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	`96.55%`	`94.92%`	`-1.64%`
src/components/applications-page/application-list/index.tsx	`90.57%`	`90.74%`	`+0.17%`
src/components/applications-page/application-list/application-list-item/index.tsx	`93.62%`	`91.67%`	`-1.95%`

…index.tsx Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

pipecd-bot · 2022-01-12T09:57:46Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

nghialv · 2022-01-12T09:58:22Z

/lgtm

khanhtc1202 · 2022-01-12T10:20:49Z

/trigger web-test

pipecd-bot · 2022-01-12T10:20:51Z

@khanhtc1202: Your requested web-test has been scheduled in response to this comment.

khanhtc1202 · 2022-01-12T10:37:22Z

/approve

pipecd-bot · 2022-01-12T10:37:25Z

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

pipecd-bot · 2022-01-12T10:38:16Z

Code coverage for javascript is 81.83%. This pull request decreases coverage by -0.04%.

File	Base	Head	Diff
src/components/application-detail-page/application-detail/index.tsx	`96.55%`	`94.92%`	`-1.64%`
src/components/applications-page/application-list/index.tsx	`90.57%`	`90.74%`	`+0.17%`
src/components/applications-page/application-list/application-list-item/index.tsx	`93.62%`	`91.67%`	`-1.95%`

khanhtc1202 · 2022-01-12T10:58:48Z

/trigger web-test

pipecd-bot · 2022-01-12T10:58:50Z

@khanhtc1202: Your requested web-test has been scheduled in response to this comment.

nghialv · 2022-01-13T01:42:11Z

/changelog

pipecd-bot · 2022-01-13T01:42:15Z

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.23.0

Notable Changes

The application description is now changeable via your application configuration file (#3017)
Fix a bug that the deployment pipeline gets invisible when it has a long sentence. (#3013)
Add a More button to fetch older deployments (#2999)
Filtering deployments by Labels is now available (#3000)
Filtering applications by Labels is now available (#2987)

Internal Changes

Show label on the app detail and list page (#3011)
Put deprecated notes on the Environment tab (#3022)
Remove duplicate value in version details on application list page (#3021)
Simplify Piped installation flow in the quickstart guide (#3020)
Fix diff description and image (#3018)
Enable to register Environment as a label (#3016)
Suggest possible labels on the apps/deploys filter (#3012)
Use filestore as datastore RFC (#2959)
Add monthly update for January 2022 (#3010)
Change text shown on deployment/application labels filter (#3005)
Show labels specified in the query parameter (#3003)

pipecd-bot added release-note-none area/web size/S labels Jan 7, 2022

pipecd-bot requested review from khanhtc1202, knanao and nghialv January 7, 2022 05:50

nakabonne changed the title ~~Show label chips on the app detail page~~ Show label on the app detail and list page Jan 7, 2022

pipecd-bot added the do-not-merge/hold label Jan 7, 2022

nakabonne added 2 commits January 11, 2022 08:26

Show label chips on the app detail page

3a96778

Show them on list

7a8cce7

pipecd-bot force-pushed the show-labels-on-app-detail branch from f01c054 to 7a8cce7 Compare January 11, 2022 08:26

Add warning on the Environment column

1c727c3

pipecd-bot added size/M and removed size/S labels Jan 12, 2022

pipecd-bot removed the do-not-merge/hold label Jan 12, 2022

nghialv reviewed Jan 12, 2022

View reviewed changes

Put blank in the label

0e87b8d

pipecd-bot added the lgtm label Jan 12, 2022

nghialv reviewed Jan 12, 2022

View reviewed changes

pkg/app/web/src/components/applications-page/application-list/index.tsx Outdated Show resolved Hide resolved

Update pkg/app/web/src/components/applications-page/application-list/…

6cf026e

…index.tsx Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>

pipecd-bot removed the lgtm label Jan 12, 2022

pipecd-bot added the lgtm label Jan 12, 2022

pipecd-bot added the approved label Jan 12, 2022

pipecd-bot merged commit 8abbf5a into master Jan 12, 2022

pipecd-bot deleted the show-labels-on-app-detail branch January 12, 2022 11:16

This was referenced Jan 13, 2022

Emphasize deprecated config fields in the doc #3028

Merged

Add a pipectl command to migrate deployment configuration files to application configuration files #3048

Merged

Show label on the app detail and list page #3011

Show label on the app detail and list page #3011

Conversation

nakabonne commented Jan 7, 2022 • edited Loading

pipecd-bot commented Jan 7, 2022

nakabonne commented Jan 7, 2022

pipecd-bot commented Jan 7, 2022

nakabonne commented Jan 7, 2022

pipecd-bot commented Jan 7, 2022

pipecd-bot commented Jan 7, 2022

nakabonne commented Jan 7, 2022

pipecd-bot commented Jan 7, 2022

pipecd-bot commented Jan 7, 2022

nakabonne commented Jan 7, 2022

nakabonne commented Jan 7, 2022

nakabonne commented Jan 11, 2022

pipecd-bot commented Jan 11, 2022

pipecd-bot commented Jan 11, 2022

pipecd-bot commented Jan 11, 2022

nakabonne commented Jan 12, 2022

nakabonne commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

nghialv Jan 12, 2022

Choose a reason for hiding this comment

nakabonne Jan 12, 2022

Choose a reason for hiding this comment

nakabonne Jan 12, 2022

Choose a reason for hiding this comment

nghialv Jan 12, 2022

Choose a reason for hiding this comment

nghialv commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

nghialv commented Jan 12, 2022

khanhtc1202 commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

khanhtc1202 commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

khanhtc1202 commented Jan 12, 2022

pipecd-bot commented Jan 12, 2022

nghialv commented Jan 13, 2022

pipecd-bot commented Jan 13, 2022

Changelog since v0.23.0

Notable Changes

Internal Changes

nakabonne commented Jan 7, 2022 •

edited

Loading