Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UpdateDeployment function from deployment store interface #3207

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Remove UpdateDeployment function from deployment store interface #3207

merged 1 commit into from
Feb 7, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.94%. This pull request increases coverage by 0.00%.

File Function Base Head Diff
pkg/datastore/deploymentstore.go deploymentStore.update -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateToPlanned -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateToCompleted -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateStatus -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateStageStatus -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateMetadata -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateStageMetadata -- 0.00% +0.00%
pkg/app/server/grpcapi/piped_api.go PipedAPI.ReportDeploymentPlanned 0.00% 0.00% +0.00%
pkg/app/server/grpcapi/piped_api.go PipedAPI.ReportDeploymentStatusChanged 0.00% 0.00% +0.00%
pkg/app/server/grpcapi/piped_api.go PipedAPI.ReportDeploymentCompleted 0.00% 0.00% +0.00%
pkg/app/server/grpcapi/piped_api.go PipedAPI.ReportStageStatusChanged 0.00% 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateDeployment 0.00% -- +-0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateDeploymentMetadata 0.00% -- +-0.00%
pkg/datastore/deploymentstore.go deploymentStore.UpdateDeploymentStageMetadata 0.00% -- +-0.00%

@nghialv
Copy link
Member

nghialv commented Feb 7, 2022

Nice.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Feb 7, 2022
@knanao
Copy link
Member

knanao commented Feb 7, 2022

Good Job:D
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit abf26a5 into master Feb 7, 2022
@pipecd-bot pipecd-bot deleted the refine-deploymentstore branch February 7, 2022 01:34
This was referenced Feb 8, 2022
Merged
Merged
@khanhtc1202 khanhtc1202 mentioned this pull request Feb 8, 2022
Merged
pipecd-bot pushed a commit that referenced this pull request Feb 8, 2022
@khanhtc1202
Remove UpdateDeploymentChain function from deploymentchain store inte…
0ff56db 
…rface (#3219)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Follow PR #3207

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao Awaiting requested review from knanao

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved area/server lgtm release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanhtc1202 @pipecd-bot @nghialv @knanao