Revert CloudRun examples to use GCR images #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanhtc1202
reviewed
May 10, 2022
| @@ -12,7 +12,7 @@ spec: | |||
| containers: | |||
| - args: | |||
| - server | |||
| image: ghcr.io/pipe-cd/helloworld:v0.30.0 | |||
| image: gcr.io/pipecd/piped:v0.27.4 | |||
There was a problem hiding this comment.
not sure why do we use piped image here instead of helloworld image 🤔
There was a problem hiding this comment.
Oops. My bad, they must be helloworld.
There was a problem hiding this comment.
@khanhtc1202 Fixed them!
nghialv
commented
May 10, 2022
nghialv
commented
May 10, 2022
nghialv
commented
May 10, 2022
nghialv
commented
May 10, 2022
nghialv
commented
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the last PR, I updated all examples to use GHCR container images, but unfortunately, Google CloudRun only allows using GCR images so this PR reverts the changes.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: