Implement lint/go command for local #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanhtc1202
reviewed
Dec 17, 2022
| lint/go: | ||
| @echo "Unimplemented" | ||
| ifeq ($(FIX),true) | ||
| docker run ${FLAGS} golangci/golangci-lint@${VERSION} golangci-lint run --fix |
There was a problem hiding this comment.
Should we add --rm to remove the container after the job is done? 🤔
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah true, I missed reading that part 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In fact, we have to fix all lint errors before using this command.
So let me fix all of them one by one in another PR.
https://github.com/pipe-cd/pipecd/runs/10154286748
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: