Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console error on web #4296

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix console error on web #4296

merged 1 commit into from
Mar 28, 2023

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Suspend this error from web console

  ● Console

    console.error
      Warning: `value` prop on `input` should not be null. Consider using an empty string to clear the component or `undefined` for uncontrolled components.
          at input
          at SelectInput (/workspace/pipecd/pipecd/web/node_modules/@material-ui/core/Select/SelectInput.js:59:24)
          at div
          at InputBase (/workspace/pipecd/pipecd/web/node_modules/@material-ui/core/InputBase/InputBase.js:219:30)
          at WithStyles (/workspace/pipecd/pipecd/web/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at OutlinedInput (/workspace/pipecd/pipecd/web/node_modules/@material-ui/core/OutlinedInput/OutlinedInput.js:137:23)
          at WithStyles (/workspace/pipecd/pipecd/web/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at Select (/workspace/pipecd/pipecd/web/node_modules/@material-ui/core/Select/Select.js:50:32)
          at WithStyles (/workspace/pipecd/pipecd/web/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at PipedSelect (/workspace/pipecd/pipecd/web/src/components/applications-page/application-filter/piped-select.tsx:851:3)
          at div
          at FormControl (/workspace/pipecd/pipecd/web/node_modules/@material-ui/core/FormControl/FormControl.js:90:24)
          at WithStyles (/workspace/pipecd/pipecd/web/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at div
          at Paper (/workspace/pipecd/pipecd/web/node_modules/@material-ui/core/Paper/Paper.js:55:23)
          at WithStyles (/workspace/pipecd/pipecd/web/node_modules/@material-ui/styles/withStyles/withStyles.js:67:31)
          at FilterView (/workspace/pipecd/pipecd/web/src/components/filter-view/index.tsx:1244:3)
          at ApplicationFilter (/workspace/pipecd/pipecd/web/src/components/applications-page/application-filter/index.tsx:1933:3)
          at ThemeProvider (/workspace/pipecd/pipecd/web/node_modules/@material-ui/styles/ThemeProvider/ThemeProvider.js:48:24)
          at Provider (/workspace/pipecd/pipecd/web/node_modules/react-redux/lib/components/Provider.js:21:20)
          at Wrapper (/workspace/pipecd/pipecd/web/test-utils/index.tsx:1389:5)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202 khanhtc1202 merged commit ec16514 into master Mar 28, 2023
@khanhtc1202 khanhtc1202 deleted the fix-console branch March 28, 2023 08:32
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants