Display MySQL user defined error in API Key UI #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
kentakozuka
commented
Sep 4, 2023
| dispatch(addToast({ message: GENERATE_API_KEY_SUCCESS })); | ||
| }); | ||
| dispatch(generateAPIKey(values)) | ||
| .then(unwrapResult) |
There was a problem hiding this comment.
Fixes an existing bug that success toast is displayed even if a request fails.
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4590 +/- ##
==========================================
+ Coverage 29.95% 29.98% +0.03%
==========================================
Files 220 220
Lines 25933 25948 +15
==========================================
+ Hits 7767 7781 +14
Misses 17518 17518
- Partials 648 649 +1
☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Sep 5, 2023
| } | ||
| if errors.Is(err, datastore.ErrUserDefined) { |
There was a problem hiding this comment.
Why do we have to change from switch case to multiple if 🤔
There was a problem hiding this comment.
If we generate an error with a message from MySQL, handling errors with a switch cannot work properly. That's why I had to change it to multi-if blocks.
There was a problem hiding this comment.
Which means the switch block can not check the type of datastore.ErrUserDefined error 🤔 It's a bit weird to me. Btw, how about adding test for this function. Looks like this function is testable without mocking anything.
There was a problem hiding this comment.
When an error message from MySQL is added to datastore.ErrUserDefined, checking with the switch block does not work because the new error is no longer the same as datastore.ErrUserDefined.
I agree with you to add tests for it 👍
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
|
@khanhtc1202 Added tests 👍 |
khanhtc1202
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Display MySQL user defined error in UI Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix Unexpected empty arrow function Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Run subtests in parallel Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Oct 11, 2023
* Display MySQL user defined error in API Key UI (#4590) * Display MySQL user defined error in UI Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix Unexpected empty arrow function Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Run subtests in parallel Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Display MySQL user defined error of piped, command, and application (#4597) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add service tags as takset task on create (#4598) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * [ECS] Fix remove all previous active tasksets on QuickSync (#4600) * Remove previous ACTIVE tasksets if present on quicksync Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Remove GetPrimaryTaskSet interface Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix unable to fetch ECS taskset tags (#4605) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Support recreate for ECS tasks (#4608) * Support singleton ECS task Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Rename singleton to recreate Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
* Display MySQL user defined error in UI Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix Unexpected empty arrow function Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Run subtests in parallel Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Nov 5, 2023
* Display MySQL user defined error in UI Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix Unexpected empty arrow function Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Run subtests in parallel Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes partof #4589
Does this PR introduce a user-facing change?: