Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display MySQL user defined error of piped, command, and application #4597

Merged

Conversation

kentakozuka
Copy link
Member

@kentakozuka kentakozuka commented Sep 8, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

part of #4589

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0cf1f84) 29.98% compared to head (9b02c98) 29.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4597   +/-   ##
=======================================
  Coverage   29.98%   29.98%           
=======================================
  Files         220      220           
  Lines       25948    25948           
=======================================
  Hits         7781     7781           
  Misses      17518    17518           
  Partials      649      649           
Files Changed Coverage Δ
pkg/app/server/grpcapi/grpcapi.go 17.96% <0.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kentakozuka kentakozuka merged commit 06b38f3 into pipe-cd:master Sep 8, 2023
12 of 13 checks passed
@kentakozuka kentakozuka deleted the display-user-defined-error-mysql branch September 8, 2023 06:12
khanhtc1202 pushed a commit that referenced this pull request Oct 11, 2023
…4597)

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
khanhtc1202 added a commit that referenced this pull request Oct 11, 2023
* Display MySQL user defined error in API Key UI (#4590)

* Display MySQL user defined error in UI

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Fix Unexpected empty arrow function

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Add tests

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Run subtests in parallel

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

---------

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Display MySQL user defined error of piped, command, and application (#4597)

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Add service tags as takset task on create (#4598)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* [ECS] Fix remove all previous active tasksets on QuickSync (#4600)

* Remove previous ACTIVE tasksets if present on quicksync

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Remove GetPrimaryTaskSet interface

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Fix unable to fetch ECS taskset tags (#4605)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Support recreate for ECS tasks (#4608)

* Support singleton ECS task

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Rename singleton to recreate

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
…ipe-cd#4597)

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: moko-poi <mokopoi44@gmail.com>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Nov 5, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants