Make actions plan preview handle timeout option

[mi11km]

What this PR does / why we need it:
The actions-plan-preview supports timeout option.
However, the actions-plan-preview finished in 5m (default timeout minutes) although setting 15m in timeout option.
Here is the actual actions logs:

To make the timeout option work, use -piped-handle-timeout when executing pipectl.

Which issue(s) this PR fixes: No issue

Does this PR introduce a user-facing change?: No

[khanhtc1202]

@mi11km Nice catch 👍
Could you sign-off your commit using git commit -s 😄

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed86af9) 30.84% compared to head (fd6132b) 30.57%.

❗ Current head fd6132b differs from pull request most recent head 089ed48. Consider uploading reports for the commit 089ed48 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4648      +/-   ##
==========================================
- Coverage   30.84%   30.57%   -0.27%     
==========================================
  Files         221      221              
  Lines       25935    25937       +2     
==========================================
- Hits         7999     7931      -68     
- Misses      17286    17358      +72     
+ Partials      650      648       -2     

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[khanhtc1202]

/review

[github-actions]

PR Analysis

Main theme

type: Refactoring
description: "Refactoring and minor updates in the GitHub integration code and plan preview functionality."

PR summary

type: Refactoring
description: "This PR refactors the code related to GitHub event parsing and plan previewing. It also includes some minor updates and improvements."

Type of PR

Refactoring

PR Feedback:

General suggestions

The changes in this PR look good overall. The refactoring has improved the structure and readability of the code. However, there are a few suggestions for further improvement:

1. Consider adding more comments or docstrings to explain the purpose and functionality of the code in github.go and planpreview.go. This will make it easier for future maintainers to understand the code.
2. Use consistent formatting for the comments in parseGitHubEvent function in github.go. The comments for the event types should start with the same indent level as the event type itself.

Code feedback

github.go

Line 55

The comments for PullRequestEvent and IssueCommentEvent in the parseGitHubEvent function should start with the same indent level as the event type itself to maintain consistent formatting.

-// - PullRequestEvent
-//   https://pkg.go.dev/github.com/google/go-github/v36/github#PullRequestEvent
-// - IssueCommentEvent
-//   https://pkg.go.dev/github.com/google/go-github/v36/github#IssueCommentEvent
+//   - PullRequestEvent
+//     https://pkg.go.dev/github.com/google/go-github/v36/github#PullRequestEvent
+//   - IssueCommentEvent
+//     https://pkg.go.dev/github.com/google/go-github/v36/github#IssueCommentEvent

planpreview.go

Line 101

The --piped-handle-timeout flag is added to the args slice, but its value is not being set. Make sure to provide a valid timeout value for this flag.

"--timeout", timeout.String(),
+	"--piped-handle-timeout", timeout.String(),

Security concerns:

no

[mi11km]

@khanhtc1202
Should the -timeout and -piped-handle-timeout options be set to different values?

[khanhtc1202]

@khanhtc1202 Should the -timeout and -piped-handle-timeout options be set to different values?

👍 I think we should keep that different and have a way to enable users to set both.

[khanhtc1202]

LGTM, thanks 🥕