Remove ModifyRules interface #4688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
nghialv,
kentakozuka and
ffjlabo
as code owners
|
@moko-poi Please take a look 👀 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4688 +/- ##
==========================================
+ Coverage 30.77% 30.82% +0.05%
==========================================
Files 221 221
Lines 26038 25975 -63
==========================================
- Hits 8014 8008 -6
+ Misses 17374 17317 -57
Partials 650 650 ☔ View full report in Codecov by Sentry. |
khanhtc1202
added a commit
that referenced
this pull request
Nov 28, 2023
khanhtc1202
added a commit
that referenced
this pull request
Nov 28, 2023
* feat(ECS): enable selection of listener rules (#4668) * feat(ECS): enable selection of listener rules Signed-off-by: moko-poi <mokopoi44@gmail.com> * Update pkg/app/piped/platformprovider/ecs/client.go Signed-off-by: moko-poi <mokopoi44@gmail.com> * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <mi11km.program@gmail.com> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <mi11km.program@gmail.com> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add Parallel() Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> * add piped-handle-timeout(input args) Signed-off-by: mi11km <mi11km.program@gmail.com> --------- Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: moko-poi <mokopoi44@gmail.com> * Increase limit of stale action operations (#4671) Signed-off-by: moko-poi <mokopoi44@gmail.com> * Add docs for k8s annotations (#4673) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com> * feat: add modifylisner and modifyrule Signed-off-by: moko-poi <mokopoi44@gmail.com> * fix: ModifyRules Signed-off-by: moko-poi <mokopoi44@gmail.com> * fix: rollback Signed-off-by: moko-poi <mokopoi44@gmail.com> * fix: routing Signed-off-by: moko-poi <mokopoi44@gmail.com> * fix: action.Type == elbtypes.ActionTypeEnumForward Signed-off-by: moko-poi <mokopoi44@gmail.com> * fix: Update ModifyListeners and ModifyRules for Selective Action Modification Signed-off-by: moko-poi <mokopoi44@gmail.com> --------- Signed-off-by: moko-poi <mokopoi44@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Masafumi Ikeyama <54844746+mi11km@users.noreply.github.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> * Remove ModifyRules interface (#4688) --------- Signed-off-by: moko-poi <mokopoi44@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Co-authored-by: Shun Takahashi <mokopoi44@gmail.com> Co-authored-by: Masafumi Ikeyama <54844746+mi11km@users.noreply.github.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
Signed-off-by: 鈴木 優耀 <suzuki_masaaki@cyberagent.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since the logic ModifyListeners had been updated to ensure only modifying the actions of kind
ActionTypeEnumForward, there is no need to separate ModifyRules and ModifyListeners.Also, no rule exists without associating with listeners in the context of ELB.
Which issue(s) this PR fixes:
Follow #4668
Does this PR introduce a user-facing change?: