Support Canary & Blue/Green for ECS by pipectl init

[t-kikuc]

What this PR does / why we need it:

[1] Support generating app.pipecd.yaml by pipectl init for ECS with

• Canary
• Blue/Green

[2] Remove required input fields to simplify user's input

Which issue(s) this PR fixes:

Fixes #4800

Does this PR introduce a user-facing change?: no

• How are users affected by this change: no
• Is this breaking change: no
• How to migrate (if breaking change): no

[codecov]

Codecov Report

Attention: Patch coverage is 88.34081% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 29.16%. Comparing base (4436527) to head (4429f42).
Report is 1 commits behind head on master.

Files	Patch %	Lines
pkg/app/pipectl/cmd/initialize/ecs.go	89.14%	16 Missing and 8 partials ⚠️
pkg/config/percentage.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4801      +/-   ##
==========================================
+ Coverage   28.91%   29.16%   +0.24%     
==========================================
  Files         317      317              
  Lines       40369    40558     +189     
==========================================
+ Hits        11674    11828     +154     
- Misses      27767    27793      +26     
- Partials      928      937       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t-kikuc]

/review

[github-actions]

PR Analysis

Main theme

Enhancement of the ECS application configuration initialization process

PR summary

This PR enhances the `pipectl init` command for ECS applications by introducing interactive prompts for user input, adding support for different deployment strategies (QuickSync, Canary, BlueGreen), and accommodating target group configurations. The code changes include the redefinition of input variables and prompt structuring, along with the generation of an application configuration YAML file based on the provided input.

Type of PR

Enhancement

PR Feedback:

General suggestions

Overall, the PR reflects a significant effort to improve the user experience when initializing ECS application configurations. It will likely make the process easier and clearer for users, especially with the direct support for different deployment strategies. However, ensuring that default values for prompts are explicitly handled and refining some parts of the code to avoid duplication will further enhance this PR.

Code feedback

- relevant file: `pkg/app/pipectl/cmd/initialize/ecs.go`
  suggestion: Consider assigning default prompt values to a constant since they are used multiple times. Duplicate literals make the process of changing a value prone to errors. (important)
  relevant line: `+		targetGroupArn string = "<YOUR_TARGET_GROUP_ARN>"`

- relevant file: `pkg/app/pipectl/cmd/initialize/ecs.go`
  suggestion: Consolidate the handling of the default deployment strategy. The prompt's default value and the switch case's default should be in sync to avoid misunderstandings. (important)
  relevant line: `+		deploymentStrategy string = "0" // QuickSync by default`

- relevant file: `pkg/app/pipectl/cmd/initialize/ecs.go`
  suggestion: Add comments to outline the structure of the deployment pipeline stages. As this is crucial for understanding the deployment strategy, comments will help maintainers and contributors understand the code faster. (medium)
  relevant line: `+				{`

- relevant file: `pkg/app/pipectl/cmd/initialize/ecs.go`
  suggestion: In the `inputECSBlueGreen` function, the `Number: 100` setting is duplicated for `ECSCanaryRolloutStageOptions` and `ECSTrafficRoutingStageOptions`. Consider abstracting this to a variable at the top of the function to avoid magic numbers and facilitate future changes. (medium)
  relevant line: `+						Number: 100,`

Security concerns:

no

The PR code does not introduce direct security concerns as it mainly pertains to command-line prompts and configuration generation, without handling external inputs that could be source vectors for attacks like SQL injection or CSRF. It's essential to ensure that future changes do not allow external influence on the prompt input, which could raise security issues.

[khanhtc1202]

Thanks, nice improvement 👍

[ffjlabo]

Thank you 👌