Use valid semver in run/pipecd command #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David <19214156+dgannon991@users.noreply.github.com>
|
@ffjlabo, @khanhtc1202 - sorry, I completely forgot to tag anyone! What do you think of this as a solution for the semver issue I was facing at kubecon? |
|
@dgannon991 I tested the command on my mac pc↓ The tag information is duplicated. 👀 BTW, I reproduced the case on the forked repo. This is because the tag information is not pulled when forked by default. 
I checked it on the forked repo with [IMO]
|
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
dgannon991
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
|
That makes sense to me (and is a lot simpler come to think of it :D) |
|
Thanks 👍 |
ffjlabo
reviewed
Apr 5, 2024
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
Merged
khanhtc1202
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Use valid semver in run/pipecd command Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> * Swapped to simpler local version Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> * Include a comment explaining why we hard coded Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> --------- Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
khanhtc1202
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Use valid semver in run/pipecd command Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> * Swapped to simpler local version Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> * Include a comment explaining why we hard coded Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> --------- Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Apr 22, 2024
#4883 #4887 #4885 #4886 #4884 #4880 (#4890) * Update contributors list (#4866) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Use valid semver in run/pipecd command (#4851) * Use valid semver in run/pipecd command Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> * Swapped to simpler local version Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> * Include a comment explaining why we hard coded Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> --------- Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Support Canary & Blue/Green for ECS by `pipectl init` (#4801) * Add expected YAML for kustomize Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add Kustomize pattern for pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add Helm pattern for pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add options for Helm Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix typo Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add ECS canary for pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add pipectl init status Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add init cmd to pipectl doc Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add pipectl init explanation Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fi pipectl init status Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Embed the simple AnalysisStage in pipeline by default Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Merge fix origin/master into pipectl-init-ecs-canary Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix prompt message and default value Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix output YAML structure by generic structs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Support Blue/Green for ECS by pipectl init Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * omitempty Percentage Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Changed default values for simpler config Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Rename funcs to avoid name conflicts with other platforms Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * [doc] Fix typo x2 in DeploymentChain (#4872) * Fix typo: archive->achieve Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix type: deployment->development Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix typos of 'achieve' and 'under development' in older docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * docs: added install method (#4875) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix unable to use SecretEncryption and Attachment features at the same time (#4855) * Add test to mention error with go templating Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Reimplement sourceprosser logic Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * SourceProssesor without processor should be marked as error Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Add test Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Enable perform template processing in chain Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix typo Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Add a caution comment of scrape_interval (#4869) * Add caution comment of scrape_interval Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Remove concrete value Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix to commit hash of v0.47.0 to fix the ref position Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Rewrite pipectl installation docs (#4877) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix typo (#4878) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Set initial-branch on git init (#4882) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Update contributors list (#4883) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Bump golang.org/x/net from 0.17.0 to 0.23.0 (#4887) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Bump golang.org/x/net in /tool/actions-plan-preview (#4885) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Bump golang.org/x/net from 0.17.0 to 0.23.0 in /tool/actions-gh-release (#4886) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Update default versions of kubectl, kustomize and helm in configuration-reference.md (#4884) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Add Homebrew Formula (#4880) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: David <19214156+dgannon991@users.noreply.github.com> Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: David Gannon <19214156+dgannon991@users.noreply.github.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: YuyaKoda <29038315+ponkio-o@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shinichi Nishimura <nshmura.s@gmail.com> Co-authored-by: Shohei Ueda <30958501+peaceiris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It introduces the use of valid semvers so the project can be run on linux using the latest helm.
Which issue(s) this PR fixes:
Fixes #4845
Does this PR introduce a user-facing change?: No
Note to reviewers: I have not been able to test this on mac, apologies, so I'd appreciate it if someone could confirm the fix is valid there as well. Thank you :) I have created this as a draft as I wanted to get some feedback on the approach of reading the release version from the RELEASE file.