Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use valid semver in run/pipecd command #4851

Merged
merged 4 commits into from Apr 13, 2024
Merged

Use valid semver in run/pipecd command #4851

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7047ef
Use valid semver in run/pipecd command
dgannon991 Mar 28, 2024
4f2628b
Merge branch 'master' into bugfix/4845/use-valid-semver
dgannon991 Apr 2, 2024
73dfdfa
Swapped to simpler local version
dgannon991 Apr 4, 2024
a9c3471
Include a comment explaining why we hard coded
dgannon991 Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -97,7 +97,10 @@ test/integration:

.PHONY: run/pipecd
run/pipecd: $(eval TIMESTAMP = $(shell date +%s))
run/pipecd: BUILD_VERSION ?= "$(shell git describe --tags --always --abbrev=7)-$(TIMESTAMP)"
# NOTE: previously `git describe --tags` was used to determine the version for running locally
# However, this does not work on a forked branch, so the decision was made to hardcode at version 0.0.0
# see: https://github.com/pipe-cd/pipecd/issues/4845
run/pipecd: BUILD_VERSION ?= "v0.0.0-$(shell git rev-parse --short HEAD)-$(TIMESTAMP)"
dgannon991 marked this conversation as resolved.
Show resolved Hide resolved
run/pipecd: BUILD_COMMIT ?= $(shell git rev-parse HEAD)
run/pipecd: BUILD_DATE ?= $(shell date -u '+%Y%m%d-%H%M%S')
run/pipecd: BUILD_LDFLAGS_PREFIX := -X github.com/pipe-cd/pipecd/pkg/version
Expand Down