Skip to content

Commit

Permalink
Limit team name length (#368)
Browse files Browse the repository at this point in the history
Add warning when it exceeds the limit
  • Loading branch information
godwhoa committed Aug 17, 2018
1 parent d91c097 commit 4f9ef73
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions piqueserver/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ def check_scripts(scripts):
return True


def validate_team_name(name):
if len(name) > 9:
log.warn("Team name's length exceeds 9 character limit. More info: https://git.io/fN2cI")
# TODO: Once issue #345 is sorted out, we can do a proper validation
# for now we just warn
# return False
return True


# declare configuration options
bans_config = config.section('bans')
logging_config = config.section('logging')
Expand All @@ -110,8 +119,8 @@ def check_scripts(scripts):
validate=lambda x: isinstance(x, (int, float)))
advance_on_win = config.option('advance_on_win', default=False,
validate=lambda x: isinstance(x, bool))
team1_name = team1_config.option('name', default='Blue')
team2_name = team2_config.option('name', default='Green')
team1_name = team1_config.option('name', default='Blue', validate=validate_team_name)
team2_name = team2_config.option('name', default='Green', validate=validate_team_name)
team1_color = team1_config.option('color', default=(0, 0, 196))
team2_color = team2_config.option('color', default=(0, 196, 0))
friendly_fire = config.option('friendly_fire', default=False)
Expand Down Expand Up @@ -325,8 +334,8 @@ def __init__(self, interface: bytes, config_dict: Dict[str, Any]) -> None:
elif self.game_mode is None:
raise NotImplementedError('invalid game mode: %s' % game_mode)
self.game_mode_name = game_mode.get().split('.')[-1]
self.team1_name = team1_name.get()
self.team2_name = team2_name.get()
self.team1_name = team1_name.get()[:9]
self.team2_name = team2_name.get()[:9]
self.team1_color = tuple(team1_color.get())
self.team2_color = tuple(team2_color.get())
self.friendly_fire = friendly_fire.get()
Expand Down

0 comments on commit 4f9ef73

Please sign in to comment.